It would be great if the module could use its own permissions instead using the general 'administer block'.

CommentFileSizeAuthor
#6 on_the_web-permissions-2557095-6.patch889 bytesckrina
#3 on_the_web-permissions-2557095-3.patch1017 bytesckrina
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ckrina created an issue. See original summary.

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
CreditAttribution: ckrina at Ymbra commented
Status: Needs work » Needs review

Here is a small patch proposal to change it.

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
CreditAttribution: ckrina at Ymbra commented
FileSize
on_the_web-permissions-2557095-3.patch1017 bytes
ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
CreditAttribution: ckrina at Ymbra commented

It would be great to have an update function to give this new permission to all the previous roles with access to to the form, but my knowledge is not good enough to write it.

rodrigoaguilera’s picture

rodrigoaguilera
Primary language Spanish
Location Madrid
CreditAttribution: rodrigoaguilera as a volunteer commented
Status: Needs review » Needs work

Yeah, I think it makes sense to have a separate permission.

+++ b/on_the_web.module
@@ -1,18 +1,30 @@
+ * Implementation of hook_permission().

The header comments should be Implements hook_blabla acording to the coding standars

Still needs a hook_update_N function to grant the new permission to all the roles that had the "administer block" permission

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
CreditAttribution: ckrina at Ymbra commented
Version: 7.x-1.4 » 7.x-1.5
FileSize
on_the_web-permissions-2557095-6.patch889 bytes

Updated patch with #5 comment.

Update function still needed.

jenlampton’s picture

jenlampton
she / her
CreditAttribution: jenlampton at Jeneration Web Development commented

Good idea :)

There are two settings forms, the one on the block as well as the one on it's own page. You'll need to update the block configuration form to use this new permission too, otherwise there's no point in having this permission (as you can override them all per-block anyway).