Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.In SwitchUserForm, we are writing good but suddenly we see this procedural - user_load_by_name().
If we dig more we see that it uses entity_load_multiple_by_properties() which is deprecated and will we removed.
So we should update our SwitchUserForm (It doesn't feel good to have procedural in Oops).
There is one more instance of user_load_by_name() in DevelController but then it also contains lots of static variant services so I think, it will be good if we replace user_load_by_name() there with other services in one go.
For now lets make SwitchUserForm ready.
Thoughts ?
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 2557087-2.patch | 2.06 KB | joshi.rohit100 |
Comments
Comment #2
joshi.rohit100Comment #3
willzyx CreditAttribution: willzyx commented@joshi.rohit100 thanks to work on this. Since currently the switch form is broken i think we should to pospone this issue to #2560539: Switch user form doesn't work
Comment #4
willzyx CreditAttribution: willzyx commentedAfter #2560539: Switch user form doesn't work SwitchUserForm no longer uses user_load_by_name(), so I'm marking this issue as fixed