Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 UTC on 18 March 2024, to get $100 off your ticket.
Problem/Motivation
Drupal\Core\DrupalKernelInterface::prepareLegacyRequest() is documented this way:
/**
* Prepare the kernel for handling a request without handling the request.
*
* @param \Symfony\Component\HttpFoundation\Request $request
* The current request.
*
* @return $this
*
* @deprecated 8.x
* Only used by legacy front-controller scripts.
*/
public function prepareLegacyRequest(Request $request);
We're supposed to be saying when @deprecated code is to be deprecated.
Proposed resolution
- Figure out if this method is deprecated.
- Figure out when it's supposed to be removed.
- Patch the doc block to say when it's supposed to be removed.
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#4 | 2556273_4.patch | 602 bytes | Mile23 |
Comments
Comment #2
Mile23Comment #3
moshe weitzman CreditAttribution: moshe weitzman at Acquia commentedDrush uses this function, but we can easily stop using it. Feel free to remove from my perspective.
Comment #4
Mile23Since we're in RC let's mark this deprecated for removal before 9.
Comment #5
xjmThanks @Mile23. Those docs look good to me, though since I'm unfamiliar with it I'll leave for someone else to RTBC.
Since this is essentially just a docs fix, it can be marked rc eligible (meaning it can go in during the RC phase without needing triage). Reference: https://www.drupal.org/core/d8-allowed-changes#rc So tagging as that. Thanks!
Comment #6
aishakadams CreditAttribution: aishakadams as a volunteer commentedThis patch performs as expected and was applied successfully (Mentor credit given to @mparker17).
Comment #7
mradcliffeThe parent issue mentions this:
I trust Mile23's patch since he documented the issue, but am confused why it's 8.0.x and not 8.0. I think that an @see would help find the legacy front controller that are the only usage of this function. At the moment it is not clear to me how to find those classes.
Comment #8
Mile23It's easier to say 8.0.x and be right than it is to say 8.0 and be right, since we don't know when the patch will be applied.
Comment #9
Mile23@mradcliffe: If that's satisfactory, could you please RTBC?
Comment #10
mradcliffeOkay, the explanation in #6 works for me.
Comment #12
AjitSLooks like a random test failure.
Comment #13
catchCommitted/pushed to 8.1.x and cherry-picked to 8.0.x. Thanks!