Problem/Motivation

Drupal has its own exception handling system, why should we have another one in twig?

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Files: 
CommentFileSizeAuthor
#3 2553993-3.patch1.94 KBdawehner
PASSED: [[SimpleTest]]: [PHP 5.5 MySQL] 104,192 pass(es). View
#2 2553993-1.patch1.33 KBdawehner

Comments

dawehner created an issue. See original summary.

dawehner’s picture

FileSize
1.33 KB

Here is just an idea

dawehner’s picture

Status: Active » Needs review
FileSize
1.94 KB
PASSED: [[SimpleTest]]: [PHP 5.5 MySQL] 104,192 pass(es). View

We could inline it instead ...

Wim Leers’s picture

So, #3 is technically faster, but #2 is easier to keep up-to-date (in sync with Twig updates).

Right?

Wim Leers’s picture

Issue tags: +Twig
dawehner’s picture

#3 is just HEAD with one less function call in the tree
#2 is without any error handling.

dawehner’s picture

I was thinking about using the twig debug options as toggle between the two.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

lauriii’s picture

Status: Needs review » Needs work
Issue tags: +Needs tests

It would be cool to see example of how this looks. I guess this could be done at least by just adding some test coverage.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.