MigrateDrupal6Test, which is meant to do a full integration test of a complete Drupal 6 site migration, is not using builders and thus not testing that capability and letting issues like #2552277: Migration d6_comment did not meet the requirements. through. We need to add builders in there to do a proper integration test. There are other issues with this test (e.g., skipping setUp() for individual test classes misses some setup that is needed for both the individual and full test cases), so maybe this should be part of a general refactoring...

CommentFileSizeAuthor
#3 migratedrupal6test-2553943-3.patch967 bytesmikeryan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mikeryan created an issue. See original summary.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan at Acquia commented

Even the simple addition of builders to MigrateDrupalTestBase::installMigrations() is going to be challenging - right off the bat it's revealing missing schema for d6_term_node, and I'm sure there'll be any number of similar issues unveiled here. So, unless we want to fix all issues this reveals in one patch, we'll have a chicken-and-egg problem - we can't have a patch narrowly focused on fixing the test until all related issues are fixed, and those issues can't have tests without this fix, unless we were to temporarily write hacky tests for the individual issues...

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan at Acquia commented
Status: Active » Needs work
FileSize
migratedrupal6test-2553943-3.patch967 bytes

The simple add-the-builder-step patch...

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Needs work » Closed (duplicate)

This is covered by #2549013: Remove load plugins, so closing this one as a duplicate.