Icon bundles from base themes not loaded

Hm... interesting. Ok. In hind sight, this function should also be checking to see if a theme's base themes are already in the $themes array as well (e.g. loop over each base theme and check if it doesn't already exist and only then add it).

I was having the same issue when I updated 2 different sites, one using Bootstrap and another using Zurb with my own font icon provider. The patch above fixed the issue and allowed me to use icons through the icon API again. Not entirely sure if the other change would need to happen since array unique works but I didn't check the full array to see if there could be a possible performance issue either. Although I have seen in some instances that array_unique has performance issues but this function is cached so it does not get ran all the time due to awesome implementation :) Therefore I am placing in Needs Review again so Mark can chime in, I can roll another patch if you want to take the array_unique out and do it the other way.

I would prefer to do a for loop with isset checks here. Having 3 array function calls on one line makes it too easy to overlook/debug. There should also be a comment explaining what is happening there and why we're looping over it I think.

@adamsro, thanks for the re-roll :) Yes, this is more of what I had in mind. The whitespace changes are fine as they're actually removing extra whitespace on those lines.

Just one tiny nitpick:

+++ b/includes/utilities.inc
@@ -274,7 +274,13 @@ function icon_enabled_themes() {
+        foreach (array_keys($theme->base_themes) as $base_theme_machine_name) {

$base_theme_machine_name is rather unnecessarily verbose. Simply using $name would suffice since it's not used anywhere else in the function.