I'm trying D6 to D8 migration. Everything looks pretty good except that comments are not migrated.

Drush reports the following.

Migration d6_comment did not meet the requirements. Missing migrations d6_node. requirements: d6_node.

I've been looking through the various documentation pages but I'm a little lost as to where to start investigating this.

The D6 site is quite a simple site. It has nothing special.

A few things I noticed:

My D6 site did not use the CCK module but the migration initially failed with:

'SQLSTATE[42S02]: Base table or view not found: 1146 Table 'ladderline.profile_fields' doesn't exist

Installing CCK fixed that.

I had issue https://www.drupal.org/node/2551147 but that was fixed by installing https://www.drupal.org/node/2549003. I then had to install the profile module on D6 which I previously was not using.

I'm happy to do further debugging etc and report results.

Thanks

Files: 
CommentFileSizeAuthor
#7 quick-comment-fix.patch479 bytesmikeryan
PASSED: [[SimpleTest]]: [PHP 5.5 MySQL] 104,190 pass(es). View

Comments

tetranz created an issue. See original summary.

tetranz’s picture

Title: Migration d6_comment did not meet the requirements. Missing migrations d6_node. requirements: d6_node. » Migration d6_comment did not meet the requirements.

Oops, didn't mean to add another comment. Just editing the excessively long title.

mikeryan’s picture

Status: Active » Postponed (maintainer needs more info)

Are you using the latest -dev of both core and migrate_upgrade? You need them both fully up-to-date...

tetranz’s picture

I think I have the latest of everything. I tried it all again tonight from scratch.

This is how I installed.

git clone --branch 8.0.x http://git.drupal.org/project/drupal.git
git clone --branch 8.x-1.x http://git.drupal.org/project/migrate_upgrade.git
git clone --branch 8.x-1.x http://git.drupal.org/project/migrate_plus.git

tetranz’s picture

I think I've found the problem.

After some poking around with debug prints and looking at other modules ...

In the migration_templates for the comment module:

d6_comment.yml lists d6_node as a migration_dependency. I think that should be d6_node:* because nodes have variants.

If I change d6_comment.yml with d6_node:* then my comments are successfully imported.

mikeryan’s picture

Project: Migrate Upgrade » Drupal core
Version: 8.x-1.x-dev » 8.0.x-dev
Component: Code » migration system
Category: Support request » Bug report
Priority: Normal » Major
Status: Postponed (maintainer needs more info) » Active
Issue tags: +Migrate critical

Ah, I missed that this fix at https://www.drupal.org/node/2530030#comment-10189624 didn't get in, need to try again to get that in quickly...

mikeryan’s picture

Status: Active » Needs review
FileSize
479 bytes
PASSED: [[SimpleTest]]: [PHP 5.5 MySQL] 104,190 pass(es). View
mikeryan’s picture

Issue tags: +blocker

re: tests (see https://www.drupal.org/node/2530030#comment-10189690) - the existing MigrateDrupal6Test should break on this, but doesn't because it isn't using the builders. That issue could be hairy - meanwhile, this fix is simple, obvious, and necessary to our goal of getting the big four migrations (terms, users, nodes, comments) for D7 done this week - can we get this in?

mikeryan’s picture

Meant to link to the issue to fix the test: #2553943: MigrateDrupal6Test needs to use builders

webchick’s picture

Issue tags: +Needs tests
mikeryan’s picture

See #2553943: MigrateDrupal6Test needs to use builders on the challenge of fixing the tests in this patch.

phenaproxima’s picture

This has a complicated relationship with #2549013: Remove load plugins.

That issue fixes this one, but it contains the tests which prove the fix. So I could provide a fail patch for this issue, but it would have to be based on the patch in that one. How should I proceed? Should we roll this fix into that patch?

phenaproxima’s picture

Status: Needs review » Postponed

Actually, on second thought, it seems to me that this is blocked by #2549013: Remove load plugins.

phenaproxima’s picture

Status: Postponed » Closed (won't fix)

Although, paradoxically, that patch will not pass testbot until this patch lands!

It think, then, that the best course of action is to close this issue and roll it into #2549013: Remove load plugins.