Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
db_select() is deprecated as of 8.0.x so needs to be replaced.
As a side issue it will clear a hidden dependency on database.inc as the database is being queried directly rather than querying the entity manager.
Comments
Comment #2
joachim CreditAttribution: joachim commentedHmm though AFAICT these are all in the multiple access system, which currently doesn't do anything.
Comment #3
martin107 CreditAttribution: martin107 commentedNow that this issue is in.
#2409835: [regression] subtypes option should not be required: leaving empty means it appliest to all
The regression has been resolved. I think this issue is worth working on..
That db_select is deprecated as of 8.0.x --so yep this is high priority.
but I have updated the issue summary to also mention the database is being queried directly rather than querying the entity manager.
I am going to work on this now.
Comment #4
joachim CreditAttribution: joachim commentedI really think this is best left for now. All the places where this is called are in dead code that doesn't do anything, and needs figuring out. It's possibly a waste of time working on it until we know what we're doing with it.
If db_select() were already gone, I'd say sure, keep the code working (in theory), but it's around till D9...
Comment #5
martin107 CreditAttribution: martin107 commentedFair enough... thanks.
Comment #6
martin107 CreditAttribution: martin107 commentedComment #7
socketwench CreditAttribution: socketwench as a volunteer commentedThere's also db_select() in CommentFlagType and NodeFlagType.
Comment #8
joachim CreditAttribution: joachim commentedNot any more :)