db_select() is deprecated as of 8.0.x so needs to be replaced.

As a side issue it will clear a hidden dependency on database.inc as the database is being queried directly rather than querying the entity manager.

Comments

joachim created an issue. See original summary.

joachim’s picture

Status: Active » Postponed

Hmm though AFAICT these are all in the multiple access system, which currently doesn't do anything.

martin107’s picture

Assigned: Unassigned » martin107
Issue summary: View changes
Status: Postponed » Active

Now that this issue is in.

#2409835: [regression] subtypes option should not be required: leaving empty means it appliest to all

The regression has been resolved. I think this issue is worth working on..

That db_select is deprecated as of 8.0.x --so yep this is high priority.
but I have updated the issue summary to also mention the database is being queried directly rather than querying the entity manager.

I am going to work on this now.

joachim’s picture

Status: Active » Postponed

I really think this is best left for now. All the places where this is called are in dead code that doesn't do anything, and needs figuring out. It's possibly a waste of time working on it until we know what we're doing with it.

If db_select() were already gone, I'd say sure, keep the code working (in theory), but it's around till D9...

martin107’s picture

Fair enough... thanks.

martin107’s picture

Assigned: martin107 » Unassigned
socketwench’s picture

There's also db_select() in CommentFlagType and NodeFlagType.

joachim’s picture

Status: Postponed » Closed (outdated)
Issue tags: -Novice

Not any more :)