Most importantly, the current release does not work properly with webform 4.x. Additionally, it would be nice to specify whether to execute the POST(s) pre or post save. For example, if used in conjunction with webform_clear, it would probably be better to post pre-save. Finally, the ability to add extra fields to pass along to the target would be a welcome addition. This would allow passing necessary key values to third parties without having to include them in the webform as hidden fields, or having to write a custom module that implements the provided hook_webform_remote_post_repost() hook.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

willvincent created an issue. See original summary.

willvincent’s picture

Here's a rather extensive patch that adds all of the above. As well as a small amount of code cleanup.

This might be good to target a 2.x branch rather than simply a minor point release, although it doesn't include any breaking changes... And there are some of those that probably should be made (namely, making targets exportable)

enrique.delgado’s picture

Hi willvincent, thanks for the patch. I took a look at it. Do you have a repo or branch that we could collaborate on? Otherwise, I can create small commits based on the patch.

enrique.delgado’s picture

Version: 7.x-1.x-dev » 7.x-2.x-dev
Assigned: Unassigned » enrique.delgado
enrique.delgado’s picture

One more thing. I can't apply the patch cleanly. Could you see if you can apply the patch on the new 7.x-2.x branch? it may be that the patch was based on an older version of the repo. Thanks!

willvincent’s picture

It's based on the 1.x branch. I don't recall seeing a 2.x branch yesterday when I created it. Is that new or was it already there?

I would be happy to commit to the project repo here, but you'd have to give me commit access to do so.

willvincent’s picture

This should apply cleanly against the 2.x branch.

Assuming the data structure is correct for webform 3.x in the 1.x branch of this module (I'm not using webform 3, so not certain) then this patch should allow support for both webform 3.x and 4.x. As well as the other changes mentioned above.

enrique.delgado’s picture

Thanks so much. Sorry for the delay. The patch applied correctly. Will do some testing and push 2.0 soon. For now, the 4.x support is is included in version 1.22 which is about to be released in a few mins.