D7 Mica Migration

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxSamirMtl2549691git

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi SamirMtl,
Removing the pareview bonus tag. Please refer Requirement to add Pareview Bonus to issue for adding the pareview bonus tag.

Haven't gone through the code, will have a look once I get time.

Thanks for your contribution!!

Review of the 7.x-1.x branch (commit b73c164):

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
  

  FILE: /home/klausi/pareview_temp/includes/mica_migration_study.inc
  ---------------------------------------------------------------------------
  FOUND 1 ERROR AFFECTING 1 LINE
  ---------------------------------------------------------------------------
   21 | ERROR | [x] Inline comments must end in full-stops, exclamation
      |       |     marks, colons, or question marks
  ---------------------------------------------------------------------------
  PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
  ---------------------------------------------------------------------------
  

• No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

1. mica_migration.module: why do you globally include all include files with module_load_include() on every single page request? You should only include the files when you actually need them, or do they contain hook implementations? Please add a comment.
2. mica_migration_menu(): $node is unused and should be removed.
3. mica_migration_menu(): if the access callback only checks for a user premission then you can use the default user_access as access callabck and the permission name as access arguments. See https://api.drupal.org/api/drupal/modules!system!system.api.php/function...
4. 'migration studies' is a strange permission name, did you mean "export migration studies" or "migrate studies to mica"?
5. mica_migration_all_studies_export_json(): if the page callback is just a form then you can use drupal_get_form as page callback and the form ID as argument. See also the hook_menu() docs.
6. "'#value' => 'Submit',": all user facing text must run through t() for translation.
7. mica_migration_create_zip_file(): $user->name should be sanitized before using in a file name, just allowing letters, numbers and underscores.

But that are not critical application blockers, so ...

Thanks for your contribution, SamirMtl!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

I got Mica2 server and drupal client up and running a few weeks ago. Now I have some spare time, I would like to help testing the migration tools. This will help me understand what else we will need to do to migrate.

I have tried installing mica_protobuf_lib, but I need some more details on what I need to do to try out the migration. Is it possible to add some brief details?

Thanks!

Hi Samir,

I see that you just changed the module that I should download, so I will try again tomorrow and see if I have success. When something comes up I will raise an issue as you suggest

Thanks

Tom