CommentFileSizeAuthor
#10 2548371_10.patch652 byteschx
#8 interdiff.txt602 byteschx
#8 2548371_8.patch588 byteschx
#6 image.png8.14 KBchx
lti.patch588 byteschx

Comments

chx created an issue. See original summary.

chx’s picture

chx commented
Parent issue: » #2527700: [meta] Improve interface doxygen where it is insufficient
dawehner’s picture

dawehner
Primary language German
commented 
+++ b/core/lib/Drupal/Core/Menu/LocalTaskInterface.php
@@ -11,6 +11,10 @@
+ * that the names of these tasks should be short verbs if possible.

Are you sure about the short verbs? core/modules/system/system.links.task.yml

for example doesn't have any of them

chx’s picture

chx commented

> Are you sure about the short verbs?

Yes, I stole this from the D7 documentation...

dawehner’s picture

dawehner
Primary language German
commented

Well, is this then necessary the right thing?

chx’s picture

chx commented
StatusFileSize
new image.png8.14 KB

grep title: core/modules/*/*.links.task.yml|cut -d: -f 3|sed "s/'//g"|while read line; do echo -n "$line" | wc -c ;done|sort -n |uniq -c

The 43 4 length titles are mostly View/List/Edit. 6 length or less is more than half. 9 or less is 80%.

dawehner’s picture

dawehner
Primary language German
commented

Well, right, but the name is not the title, right?

chx’s picture

chx commented
StatusFileSize
new 2548371_8.patch588 bytes
new interdiff.txt602 bytes

AAAAA! I guess the D7 docs are wrong too then? Thanks for being so patient with me. I didn't realize the problem is in name vs title.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Needs work

Looks good... possibly a bit of grammar/punctuation would help:
- comma before "though"
- title of these tasks => titles of these tasks

chx’s picture

chx commented
StatusFileSize
new 2548371_10.patch652 bytes
chx’s picture

chx commented
Status: Needs work » Needs review
jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Fixed 
+++ b/core/lib/Drupal/Core/Menu/LocalTaskInterface.php
@@ -11,6 +11,12 @@
+ * @see \Drupal\Core\Menu\LocalTaskManagerInterface ¶

oops. trailing space here.

Rest looks good! So fixed on commit.

  • jhodgdon committed e4db6c6 on 8.0.x 
    Issue #2548371 by chx, dawehner, jhodgdon: Expand LocalTaskInterface...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.