I first heard about this issue from @mpotter who encountered it while working on oa_radix (where he included a workaround) but now I just encountered it too while working on a sub-theme for a client.

You can reproduce this by:

  1. Installing Panopoly
  2. Enabling Radix
  3. Creating a new Content Page
  4. Clicking the "Media" button in the WYSIWYG
  5. Noticing that there is no big red X button in the upper-right corner of the dialog

The reason for this problem comes from a link that @mpotter put in the comments by his workaround:

http://stackoverflow.com/questions/17367736/jquery-ui-dialog-missing-clo...

Basically, we need to either (a) get Bootstrap's Javascript to load before jQuery UI or (b) include a workaround like the one that @mpotter put into oa_radix.

I'm going to look at (a) first, because it would seem like a cleaner solution...

CommentFileSizeAuthor
#5 interdiff.txt2.5 KBdsnopek
#5 radix-dialog-close-icon-2546874-5.patch2.61 KBdsnopek
#2 radix-dialog-close-icon-2546874-2.patch2.22 KBdsnopek
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dsnopek created an issue. See original summary.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
Status: Active » Needs review
FileSize
radix-dialog-close-icon-2546874-2.patch2.22 KB

Here's a patch that reorders the Javascript files on the page and solves the problem in my testing!

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented

Discussing this with @mpotter on IRC, he recommended actually querying the group/weight for jQuery or jQuery UI rather than hardcoding the values. In hook_libraries_info_alter() we should be able to get that from $libraries but in radix_preprocess_html() we'll have to call drupal_get_library().

It probably makes sense to get the group/weight for jQuery UI, and subtract 1 (because we know it has to come after jQuery) rather than doing something messy with taking the weight's for both and averaging them (which is roughly where the value currently hard-coded in the patch comes from).

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
Issue summary: View changes
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
FileSize
radix-dialog-close-icon-2546874-5.patch2.61 KB
interdiff.txt2.5 KB

Here's a new version of the patch that takes @mpotter's suggestion!

  • dsnopek committed b7e0e0c on 7.x-3.x 
    Issue #2546874 by dsnopek: jQuery UI dialog missing close icon
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
Status: Needs review » Fixed

I was hoping to get @mpotter to test this, but it has gotten a bunch of testing with client sites, and we're still getting this reported in the Panopoly queue, so I'm going to go ahead and just commit it. :-)

shadcn’s picture

shadcn CreditAttribution: shadcn commented

Thanks @dsnopek.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.