Description
The purpose of this module is simple; bring the free, open source, and accessible HTML5 media player "Able Player" to Drupal.
Able Player is a jQuery plugin that acts on existing HTML5 audio and video elements to provide a high level of accessibility, particularly with the display of captions, audio descriptions, and interactive transcripts. It is unique among existing HTML5 media players in that it is designed first and foremost for accessibility, with a professional technology accessibility specialist as its primary developer.
This module works with File Entity to integrate Able Player as a file formatter, allowing Able Player to work with any applicable media anywhere in a Drupal site. Users simply enable 'Able Player' as the default file display for audio and video files and Able Player will be used to render the supported file formats.
This module leverages the Libraries API, Modernizr API, and File Entity API for a simple and extensible implementation.
Project Links
Project Page
Able Player Home Page
Clone the Repository
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/npacker/2508441.git ableplayer
Comment | File | Size | Author |
---|---|---|---|
#6 | 2508441-1.patch | 14.11 KB | theMusician |
Comments
Comment #2
npacker CreditAttribution: npacker commentedComment #3
PA robot CreditAttribution: PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxnpacker2508441git
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #4
npacker CreditAttribution: npacker commentedFixed some issues found in automatic code review.
Comment #5
npacker CreditAttribution: npacker commentedComment #6
theMusician CreditAttribution: theMusician as a volunteer and commentedRunning the automated project application review script generated a few minor formatting suggestions.
I have attached a patch which I think cleans up the formatting portion of the review.
A few warnings were generated about undefined variables as well in the theme.inc file.
Explicitly declaring those should clean it up and we can move to reviewing the code for potential security issues.
Comment #7
npacker CreditAttribution: npacker commentedPatch applied to fix remaining significant automated review issues.
Comment #8
npacker CreditAttribution: npacker commentedComment #9
npacker CreditAttribution: npacker commentedComment #10
npacker CreditAttribution: npacker commentedComment #11
Amerie CreditAttribution: Amerie commentedI looked through the code for security issues and found nothing wrong. I did notice a couple of very minor things that could be improved if you have time:
Comment #12
Amerie CreditAttribution: Amerie commentedIssues above should not stop this from being promoted to a full project.
Comment #13
Sumit kumar CreditAttribution: Sumit kumar as a volunteer commentedThanks for contribution @npacker
code is working for me
Comment #14
mgiffordHappy to see this is moving along. I haven't had time to work with it, but know that this module will benefit a lot of organizations who need an accessible media player. Happy it's RTBC!
Comment #15
kattekrab CreditAttribution: kattekrab at Creative Contingencies commented@npacker - this is RTBC - looks like you need to review 1 more project to get the PA bonus - and then this project can be approved and promoted!
Comment #16
npacker CreditAttribution: npacker commentedComment #17
npacker CreditAttribution: npacker commentedComment #18
klausimanual review:
Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.
Comment #19
klausiThe XSS test string I used for the exploit:
a"><script>alert('XSS');</script><a class="
Comment #20
npacker CreditAttribution: npacker commented@klausi: Thank you for the review!
Comment #21
npacker CreditAttribution: npacker commentedComment #22
npacker CreditAttribution: npacker commentedComment #23
andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer and at Annertech commentedAll of @klausi's issues from comment #18 have been addressed, so back to RTBC?
It's frustrating that the product review bonus has been lost, and another 3 reviews are needed, but that seems to be the current policy.
@npacker is already making good use of the issue queue for the module. At the moment there are a couple of open issues there, but I don't see them as blockers to project promotion, and both issues are making good progress.
Comment #24
MiSc CreditAttribution: MiSc as a volunteer commentedDoing some clean up in the queue of old issues, and see nothing that should stop you from getting the git vetted user role, so:
Thanks for your contribution, npacker!
I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thanks to the dedicated reviewer(s) as well.
Comment #25
npacker CreditAttribution: npacker commentedThanks to @MiSc and to all who reviewed!