Problem/Motivation

Currently, the core/scripts/dump-database-d8-mysql.php script takes no options, and dumps everything aside from a few excluded tables, and some data (eg cache tables) are excluded.

When working on tests for #2544954: SqlContentEntityStorageSchema does not detect column-level schema changes in non-base-fields, it will be very nice to be able to say only export data for these certain tables (then the test can load an additional file that doesn't include the table create statement). Similarly, only exporting schema for a list of tables will also be useful.

This is by no means urgent, as this can be done by hand currently, but it would be nice DX for future upgrade path issues.

Proposed resolution

Add --schema-only and --data-only options, and an optional tables argument.

The new command could, for instance, export just the node and node_field_data insert statements using:

./dump-database-d8-mysql.php --data-only node node_field_data

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#24 interdiff_22-24.txt1.85 KBsahil.goyal
#24 2544972-24.patch5.2 KBsahil.goyal
#22 interdiff-2544972-19-22.txt1013 bytesmarkdorison
#22 2544972-22.patch4.01 KBmarkdorison
#21 2544972-nr-bot.txt1.31 KBneeds-review-queue-bot
#19 interdiff_18-19.txt1.35 KBpooja saraah
#19 2544972-19.patch4.05 KBpooja saraah
#18 data-only-2544972-10.patch4.05 KBAnchal_gupta
#9 data-only-2544972-9.patch3.99 KBBerdir
#1 dbdumpcommand-options-2544972-01.patch7.88 KBjhedstrom
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 commented
Issue summary: View changes
Status: Active » Needs review
FileSize
dbdumpcommand-options-2544972-01.patch7.88 KB

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

markdorison’s picture

markdorison
he/him
CreditAttribution: markdorison at Chromatic commented
Version: 8.1.x-dev » 8.3.x-dev
Status: Needs review » Needs work

Patch no longer applies cleanly. I believe the schema-only option may have already been implemented.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs work » Needs review
FileSize
data-only-2544972-9.patch3.99 KB

Didn't update the tests yet, but this is a data-only command similar to the existing schema-only option. They are mutually exclusive, using any data-only arguments will only export data for only those tables.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented
Related issues: +#3213633: Improve DX of maintaining migration database fixtures: provide an option for creating per-table database fixtures in DbDumpcommand

Adding a related issue, which may be a duplicate. Maybe I can look later, unless someone does that before I get back here.

quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented
Issue tags: -D8 upgrade path

Looked into the more today and the related issue added in #16 is not a duplicate.

While this may be useful for working with dumps this issue itself does not need an upgrade path, so removing tag.

Anchal_gupta’s picture

Anchal_gupta CreditAttribution: Anchal_gupta at Srijan | A Material+ Company for Drupal India Association commented
FileSize
data-only-2544972-10.patch4.05 KB

Rerolled patch #9, for 9.5x. please review

pooja saraah’s picture

pooja saraah CreditAttribution: pooja saraah at Srijan | A Material+ Company for Drupal India Association commented
FileSize
2544972-19.patch4.05 KB
interdiff_18-19.txt1.35 KB

Fixed Failed commands on #18
Attached patch against Drupal 9.5.x

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

needs-review-queue-bot’s picture

needs-review-queue-bot CreditAttribution: needs-review-queue-bot as a volunteer commented
Status: Needs review » Needs work
FileSize
2544972-nr-bot.txt1.31 KB

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

markdorison’s picture

markdorison
he/him
CreditAttribution: markdorison at Chromatic commented
Status: Needs work » Needs review
FileSize
2544972-22.patch4.01 KB
interdiff-2544972-19-22.txt1013 bytes

Updated patch to resolve NR bot issue.

Status: Needs review » Needs work

The last submitted patch, 22: 2544972-22.patch, failed testing. View results

sahil.goyal’s picture

sahil.goyal CreditAttribution: sahil.goyal as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented
FileSize
2544972-24.patch5.2 KB
interdiff_22-24.txt1.85 KB

Trying to resolve the errors/warnings for the current version 10.1.x and also attaching the interdiff file.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.