The Views in CiviCRM Dashlets module enables creation of customizable dashlets with integrated Views displays. These dashlets are used on the CiviCRM home page and each display creates a new dashlet.
This module was displayed at Civicon Denver 2015

Sandbox Page
Clone Command: git clone --branch 7.x-1.x http://git.drupal.org/sandbox/brandonferrell/2389543.git views_civicrm_dashlets

Will not fix below pareview errors. The Views display plugin class format uses lowercase and underscores.

FILE: ...pareview/pareview_temp/views_civicrm_dashlets_plugin_display_page.inc
---------------------------------------------------------------------------
FOUND 8 ERRORS AFFECTING 7 LINES
---------------------------------------------------------------------------
11 | ERROR | Class name must begin with a capital letter
11 | ERROR | Class name must use UpperCamel naming without underscores
16 | ERROR | Public method name
| | "views_civicrm_dashlets_plugin_display_page::option_definition"
| | is not in lowerCamel format
30 | ERROR | Public method name
| | "views_civicrm_dashlets_plugin_display_page::uses_breadcrumb"
| | is not in lowerCamel format
39 | ERROR | Public method name
| | "views_civicrm_dashlets_plugin_display_page::options_summary"
| | is not in lowerCamel format
77 | ERROR | Public method name
| | "views_civicrm_dashlets_plugin_display_page::options_form"
| | is not in lowerCamel format
118 | ERROR | Public method name
| | "views_civicrm_dashlets_plugin_display_page::options_submit"
| | is not in lowerCamel format
143 | ERROR | Public method name
| | "views_civicrm_dashlets_plugin_display_page::execute_hook_menu"
| | is not in lowerCamel format
---------------------------------------------------------------------------

Manual reviews of other projects

Comments

brandonferrell’s picture

brandonferrell CreditAttribution: brandonferrell commented
Issue summary: View changes
brandonferrell’s picture

brandonferrell CreditAttribution: brandonferrell commented
Status: Needs review » Active
brandonferrell’s picture

brandonferrell CreditAttribution: brandonferrell commented
Status: Active » Needs review
brandonferrell’s picture

brandonferrell CreditAttribution: brandonferrell commented
Issue summary: View changes
PA robot’s picture

PA robot CreditAttribution: PA robot commented
Issue summary: View changes
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxbrandonferrell2389543git

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

brandonferrell’s picture

brandonferrell CreditAttribution: brandonferrell commented
Issue summary: View changes
brandonferrell’s picture

brandonferrell CreditAttribution: brandonferrell commented
Status: Needs work » Needs review
brandonferrell’s picture

brandonferrell CreditAttribution: brandonferrell commented
Issue summary: View changes
brandonferrell’s picture

brandonferrell CreditAttribution: brandonferrell commented
Issue summary: View changes
brandonferrell’s picture

brandonferrell CreditAttribution: brandonferrell commented
Issue tags: +PAreview: review bonus
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi commented

Filed #2579981: Commits not shown on project page and in cgit because I don't see all commits in cgit.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi commented
Assigned: Unassigned » er.pushpinderrana
Status: Needs review » Reviewed & tested by the community
Issue tags: -PAreview: review bonus

manual review:

  1. "variable_del('disabled-' . $view->name);": all variables defined by your module need to be prefixed with your module's name. Otherwise you get name clashes with other modules.
  2. _views_civicrm_dashlets_menu_delivery_callback(): not sue I understand this correctly: you print $content, then you print a full HTML with $content again? why? Please add a comment.

The wrong variable names is a major problem, but not a critical application blocker, so I think this is RTBC. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to Pushpinder as he might have time to take a final look.

er.pushpinderrana’s picture

er.pushpinderrana CreditAttribution: er.pushpinderrana as a volunteer and at Publicis Sapient for Publicis Sapient commented
Assigned: er.pushpinderrana » Unassigned
Status: Reviewed & tested by the community » Fixed

Automated review shows some false notices otherwise it looks good.

From a manual review I didn't find anything major except the one pointed by Klausi in last review(#12). Please make sure you should fix it before publish it as full project. As this is already in RTBC so...

Thanks for your contribution, Brandon Ferrell!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.