Add permission to *have* a personal contact form

That is exactly what I needed for the site I am working on as well... THANK YOU!! Now I want to try and figure out how to do the same thing to get rid of the Locale settings under the Edit node tab. Thank you again, greatly appreciated! YAH!

We should probably use some kind of permission for this. Moving to 7.x.

All you need for the upate function is just to add the permission to the authenticated user role:

function system_update_numberhere() {
  $ret = array();
  db_insert('role_permission')
    ->fields(array(
      'rid' => DRUPAL_AUTHENTICATED_RID,
      'permission' => 'new permission here',
    ))
   ->execute();
  return $ret;
}

Sorry, but this entire contact form issue is wrong from start.

To have a site-wide contact form (which I'm sure is a must to any site -- use it Drupal or not) and to be able to provide personal contact forms for your users are two entirely diferent use cases.

The correct path IMHO is to split the module in two: contact.module and personal_contact.module (or the like). Admins wanting only a site-wide contact form would enable only the former, while others wanting to provide personal contact forms for your users would enable only the latter.

I even bet this will also simplify the code a lot.

Just my $.02.

> Admins wanting only a site-wide contact form would enable only the former, while others
> wanting to provide personal contact forms for your users would enable only the latter.

I'm using drupal 6 and was looking for the answer to this.
I'm currently using this unofficial module provided by mattB:
http://drupal.org/node/138574#comment-928203
It enables you to turn off personal CFs, and leave the site-wide CF on.

Is this still my best option for D6?

I hope that whenever this feature gets looked at properly, Drupal ends up with a kick-ass contact system
for D7. The D6 contact form was obviously not prioritised over peripheral features like the color module.

I don't touch the contact module anymore for a long time. This personal contact "feature" is just a show-stopper for the sites I worked on recently, as none of then wanted to have to deal with personal contact forms.

All contact forms on the sites I create are now handled using the webforms modules. Webforms may sound overkill for the task, but it's the only alternative I know of, and it does the job very well.

There used to be a "feedback" module which provided site-wide personal with some other nice features (and without the hassles of the contact form), but it's know a discontinued project (don't use feedback2 — it's a completely different animal).

BTW, if you stick to the contact module you may want to take a look on the Contact no CC module, which removes the carbon copy checkbox (a "feature" which IMHO should also be provided by a separate module, or at least have a setting to be turned off).

Too late for D7, so bumping to D8.

subscribing

this would be a good distinction to make

Awesome patch, does the job perfectly.

uff-da. I made a patch before discovering this issue.

Rerolled the patch against 8.x, moved system_update_7036() to contact_update_8000(), and adjusted some wording.

It would be great to get something like this into core; For every site i build, I enable the site contact form and then disable the personal contact form in code.

Exposing this as a permission would rock.

ack. rogue semi-colon. re-rolling.

thanx, is the D8 patch valid for D7 as well?

Would most appreciate this feature in D7 :)

tag

The patch in #18 seems to be failing on a Drupal 8.0-dev minimal install:

theamoeba@~/development/drupal8> git apply -v contact-personal-contact-form-permission-254460-18.patch
Checking patch core/modules/contact/contact.install...
Checking patch core/modules/contact/contact.module...
error: while searching for:
'#title' => t('Contact settings'),
'#weight' => 5,
'#collapsible' => TRUE,
);
$form['contact']['contact'] = array(
'#type' => 'checkbox',

error: patch failed: core/modules/contact/contact.module:220
error: core/modules/contact/contact.module: patch does not apply

Rerolling patch

Patch became stale. Rerolled manually just copypasting.
Code looks OK. Tested and works as advertised. Needs tests, so tagging.
Would this be backportable to 7.x? As long as we keep the appropiate update hook, looks like it's safe to.
In such case, we may also add a link meanwhile to this issue somewhere in this page: http://drupal.org/documentation/modules/contact

Stale. Reroll chasing HEAD.

+  db_insert('role_permission')
+    ->fields(array(
+      'rid' => DRUPAL_AUTHENTICATED_RID,
+      'permission' => 'administer own contact form',
+    ))
+    ->execute();

Needs to be in its own update function not an existing one.

Done.

Unassigning.

Looks good just needs some tests now :)

Here are them. They're supposed to fail. Full patch will follow.

Full patch.

I tested this in a clean D8 install.

• User X/Y are able to change their own settings depending on the "Administer own personal contact form" permission
• User X cannot contact Y when Y has disabled the checkbox.
• User X can contact Y when Y has enabled the checkbox
• User X/Y cannot use the personal contact form if the "Use users' personal contact forms " is not set

However there still seems to be one "issue".
If "Administer own personal contact form" is disabled the uses will never know other persons are able to send them emails using this Drupal site. The "Use users' personal contact forms" can be set.

This way user X can send emails to user Y and user Y cannot disable this.
Like I said this might not be important.

Thanks for thorough testing, Joris.
The purpose of this permission is to remove any user control of personal contact forms. The site admin would set the default personal contact form to either on or off and force it via this permission.
I see no side effects neither on defaulting PCF to on or off anyway and forcing it, altough it sounds a bit "spammy". But that's up the site builder/admin, IMO.
This was mainly for addressing the "no-PCF for anybody" use case. Are you thinking in any particular use case where it has side effects?
TIA.

(double submit, sorry)

This still needs tests as in simple test

Doh my bad I missed the last patch :(

No, not an use case in particular.
Was just mentioning it because it is an option.
I agree it is an admin issue

Patch became stale. Reroll.

Patch applies and confirmed that this works as expected, as noted in #33 (and clarified in #34).

Here's what the permissions look like:

Here's admin (user1) viewing user2. Admin has the permission to use users' contact forms:

And here's user2 viewing admin. As only an authenticated user, user2 does not have the permission to use users' contact forms, even though admin's contact form is enabled:

Personally, I think the phrasing of the permission, "Use users' personal contact forms," is a little cumbersome. I'd prefer something like "Use personal contact forms of users who enable them," or if that's too long, "Use personal contact forms" as the permission, with "Use the personal contact form for users who enable it" as the help text.

But since that's just my personal opinion on wording, I'm going to go ahead and mark this as RTBC and if someone higher up than me wants to quibble with the language, they can :)

Thanks a lot for the detailed review. The "Use users' personal contact forms" text might be improved, but that should be dealt with in another issue, since this patch only adds the "Administer own personal contact form" permission.

(To core gatekeepers) Also, this patch seems an easily backportable one if we add an update hook that grants this new permission to those already having the "Administer contact forms and contact forms settings".

#40: drupal--254460--add-administer-own-contact-form-perm-40.patch queued for re-testing.

#40: drupal--254460--add-administer-own-contact-form-perm-40.patch queued for re-testing.

+++ b/core/modules/contact/contact.installundefined
@@ -110,6 +110,19 @@ function contact_update_8003() {
+ * Set permission so the personal contact form's "Contact Settings" does
+ * not disappear from user account pages when upgrading from 7.x to 8.x

Oops, let's fix this summary so that it's only one line of 80 characters or fewer: http://drupal.org/node/1354#functions

Fixed.
Would love to get feedback about #42 when this one gets commited.

(To core gatekeepers) Also, this patch seems an easily backportable one if we add an update hook that grants this new permission to those already having the "Administer contact forms and contact forms settings".

I don't think we can actually backport this. Consider this scenario: Someone has already implemented this functionality in a contrib or custom module. Our update hook runs and suddenly all users that previously did not have access are granted it, causing a security issue.

Also, do we maybe want to default to this permission being granted when contact is installed?

Too bad, I didn't thought on the scenario you explain in #48. Let's leave it for contrib.
As for #49, I can imagine valid reasons to enable it on install. However, I grepped for hook_installs in other modules and granting some permission on install would be a first, and I can also think of valid reasons of installing with it off by default depending on the use case. Maybe install profiles are the right place?
Additionally, the usual 'secure by default' kinda of reasoning would leave this off and since 8.x is a brand new Drupal, one can expect some default behavior changes and this will allow discovering the new feature.
Of course, I might have overlooked some reason behind your proposal and would love to know more of it.

This was a great thread! Now, lets so it again for D7 :) I need this patch!!

#47: drupal--254460--add-administer-own-contact-form-perm-47.patch queued for re-testing.

Reroll, awaiting for feedback on default permission setting on #50. Again, some changes in freshly installed sites configuration are to be expected in a new version. Why not let users discover the new permission?
Anyway, Drupal 8 will have a long release notes file ;)

#54: drupal--254460--add-administer-own-contact-form-perm-54.patch queued for re-testing.

Tagging

Reroll, awaiting for feedback on default permission setting on #50. Again, some changes in freshly installed sites configuration are to be expected in a new version. Why not let users discover the new permission?
Anyway, Drupal 8 will have a long release notes file ;)

Reroll of #59, awaiting feedback on #50.

Setting to active to get feedback on #50.
Also, found https://drupal.org/project/contact_permissions on contrib.

This may be outside the scope of this issue, but if the intent is to allow administrators to take management of personal contact forms out of the hands of users, should there be any better support for that? Some way to tell who has forms enabled and who does not, and perhaps to be able to enable/disable forms in batch?

Removing the "Novice" tag since this looks like it needs feedback from a more experienced dev.

Related #1191464: Inconsistent behaviour in personal contact form for users created before versus after contact module is enabled

the related should be affected by the issue

does not fit into beta, let's focus on #124969: Contact form opt-out line should be excluded from admin-sent and sender-copy e-mails

Seven years is long enough.