Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Follow-up to #1342054: [META] Clean up templates and CSS
Problem/Motivation
- Bartik's template files need to be assessed and cleaned up of redundant markup, bad formatting and ID's.
- Bartik's CSS files need to follow Drupal's CSS Coding Standards.
Proposed resolution
For this issue we take "colors.css" within Bartik in css/colors.css plus any template file associated with the CSS and clean them up.
CSS formatting tasks to do
- The CSS file needs to use the correct Comment formats - see guidelines here and also reference other fixed Bartik CSS files for wording guidelines.
CSS architecture tasks to do
- Replace any ID's with classes in the CSS files and Twig files associated with it - see guidelines here.
CSS cleanup tasks to do
- Remove any CSS that repeats styles from elsewhere in Bartik and therefore are not needed in this file.
- Check all of the selector rules are correct and are currently in use on the frontend of Bartik. Fix any broken ones found.
Remaining tasks
- Write a patch containing as much as the above as possible.
- Post a patch with screenshots.
- Visual review of a patch - check the Colors Module visually with and without patch applied. Take screenshots.
- Code review of a patch - check the code follows coding standards, suggest improvements if needed in a comment.
- Produce a new patch with improvements if needed.
User interface changes
None
API changes
None
Data model changes
None
Beta phase evaluation
Issue category | Task because it is refactoring CSS and templates in Bartik |
---|---|
Issue priority | Not critical because Bartik functions fine we are just doing cleanup tasks |
Unfrozen changes | Unfrozen because it only changes CSS and markup |
Prioritized changes | The main goal of this issue is usability of the Bartik's codebase |
Disruption | non-Disruptive as it is just changing markup and CSS |
Comment | File | Size | Author |
---|---|---|---|
#7 | clean-up-colors-bartik-2542610-7.patch | 3.29 KB | SixZeroNine |
#6 | clean-up-colors-bartik-2542610-6.patch | 4.85 KB | SixZeroNine |
#6 | modifications.png | 62.5 KB | SixZeroNine |
#6 | original.png | 57.16 KB | SixZeroNine |
Comments
Comment #1
emma.mariaComment #2
SixZeroNine CreditAttribution: SixZeroNine at Develomon for FFW commentedComment #3
emma.mariaHello @SixZeroNine do you need help working on this issue? I am available on IRC to help out.
Also you should only assign issues to yourself if you are actively working on a patch. If you are no longer going to work on this issue can you please unassign?
Thanks.
Comment #4
SixZeroNine CreditAttribution: SixZeroNine at Develomon for FFW commented@emma.maria still working on it.
Thanks.
Comment #5
emma.mariaNo worries! Also if you need any help, feel free to ping me or post what you have so far.
Comment #6
SixZeroNine CreditAttribution: SixZeroNine at Develomon for FFW commentedI removed ID's from colors.css and replace them with classes,
edited .twig files associated with it.
Comment #7
SixZeroNine CreditAttribution: SixZeroNine at Develomon for FFW commentedComment #8
SixZeroNine CreditAttribution: SixZeroNine at Develomon for FFW commentedComment #9
LewisNyman CreditAttribution: LewisNyman at Wunder commentedIt might be worth waiting for #2466983: Clean up the "header" component in Bartik and a few others to get in
Comment #10
lauriiiComment #11
dcrocks CreditAttribution: dcrocks as a volunteer commentedCan I ask why the colors.css file still exists? Wouldn't it be better to have its contents dispersed to the components it is actually affecting?
Comment #12
emma.mariaHi @dcrocks the color.css file is for the color module and we were told by Jen Simmons to leave it as is and not break it up.
This comment in another issue tries to explain why.
Comment #13
LewisNyman CreditAttribution: LewisNyman at Wunder commentedThis page has more information: https://www.drupal.org/node/108459
Comment #14
LewisNyman CreditAttribution: LewisNyman at Wunder commentedMaybe we should add a comment to the top that explains why it's needed?
Comment #15
dcrocks CreditAttribution: dcrocks as a volunteer commentedOk, I remember now. I actually was slightly involved with this feature when drupal 7 was in beta.
Comment #16
mgiffordComment #28
quietone CreditAttribution: quietone at PreviousNext commentedBartik has been removed from core. This was discussed in #frontend and markconroy said that this can move to the contrib project. I am doing that now.