Title: Concept: Responsive Image Styles
Section: Setting Up Content Structure
File name: structure-image-responsive.txt
Covers: Tell about the Responsive Image module, which can be used to set up responsive image styles that come into play if your theme has Breakpoints defined. Don't actually cover how to do this though.
Index: Security

Attribution

See https://userguide-drupal.redesign.devdrupal.org/guidelines/guidelines.ht...

<<structure-image-styles>>::
  Adapted by https://www.drupal.org/u/batigolix[Boris Doesborg] from the the drupal.org community documentation at https://www.drupal.org/documentation/modules/responsive_image. Copyright 2000-2015 by the individual contributors to the
  https://www.drupal.org/documentation[Drupal Community Documentation]
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

batigolix’s picture

Assigned: Unassigned » batigolix
Issue summary: View changes

claiming

batigolix’s picture

Status: Active » Needs review
FileSize
1.22 KB

First attempt. I kind of struggled with the wording, using the hook_help text as a base.

I remember (vaguely) struggling with that same text for the hook_help text.

Let me know what you think

jhodgdon’s picture

Status: Needs review » Needs work

Hm, we may have a copyright/license problem here, because technically anything in Drupal Core is GPL, and our user guide is CC-BY-SA. That said, we've always copied freely between Drupal Core and drupal.org documentation, so I'm not really too worried about it. But I think in the attributions we should attribute the d.o page for the module (which has the compatible licensing), rather than the hook_help() in Core.

Anyway, that aside... I think the text looks pretty good! A few small suggestions:

a) We should mention that it's the Responsive Image module that provides responsive image styles.

b) We probably need an index entry for Breakpoint as well? We can take care of that in the Guidelines phase too, but might as well add it now.

c) The title of the topic should be "Concept: Responsive Image Styles" [concept is missing]

d) I was also wondering about "different screen widths". I think breakpoints can also be defined by screen height (although that is uncommon), right?

e) Would it be useful to mention that they only work if your theme has breakpoints defined? It is kind of implied but not explicitly stated.

f) In the Additional section, https://www.drupal.org/node/1388492 has page title "Responsive web design" (note space between web and design)

batigolix’s picture

Issue summary: View changes
batigolix’s picture

I addressed the point in #3. See the new text in the attachment

batigolix’s picture

Status: Needs work » Needs review
batigolix’s picture

Assigned: batigolix » Unassigned
jhodgdon’s picture

Status: Needs review » Fixed

Looks great, thanks! Added to the guide source; will get it up on the site later today when I finish several reviews.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.