Line 139 of cdn.module - pretty sure "count($servers > 1)" should be "count($servers) > 1". The code's always taking this block and I only have one server.

Pretty sure it doesn't matter too much - $choice should always be "0" in this case I think, since the remainder of anything divided by 1 will be 0.

CommentFileSizeAuthor
#2 2540260-2.patch617 bytesswentel
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Version: 7.x-2.6 » 7.x-2.x-dev
Priority: Minor » Normal

OMG! So stupid! Clearly this would never have worked for some scenarios. Which means this is probably not used by anybody. And hence qualifies for removal.

Mind rolling a patch? :)

swentel’s picture

swentel CreditAttribution: swentel commented
Status: Active » Needs review
FileSize
2540260-2.patch617 bytes
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Needs review » Reviewed & tested by the community
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Reviewed & tested by the community » Fixed

Finally committed, thanks!

  • Wim Leers committed 19e6723 on authored by swentel 
    Issue #2540260 by swentel: count($servers > 1) should be count($servers...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.