Do not use t() in exceptions

Problem/Motivation

We currently use t() in some exceptions, but we don't translate exceptions. In the installer there are some

Examples:

./includes/common.inc:    throw new Exception(t('Archivers can only operate on local files: %file not supported', array('%file' => $file)));
./includes/install.core.inc:        throw new InstallerException(t('Missing profile parameter.'));
./includes/install.core.inc:        throw new InstallerException(t('Sorry, you must select a language to continue the installation.'));
./includes/install.inc:      throw new Exception(t('Failed to modify %settings. Verify the file permissions.', array('%settings' => $settings_file)));
./includes/install.inc:    throw new Exception(t('Failed to open %settings. Verify the file permissions.', array('%settings' => $settings_file)));
./includes/install.inc:      throw new Exception(t('The directory %directory could not be created or could not be made writable. To proceed with the installation, either create the directory and modify its permissions manually or ensure that the installer has the permissions to create it automatically. For more information, see the <a href="@handbook_url">online handbook</a>.', array(
./includes/update.inc: * throw new UpdateException(t('Description of what went wrong'));
./lib/Drupal/Core/Archiver/Zip.php:      throw new ArchiverException(t('Cannot open %file_path', array('%file_path' => $file_path)));
./lib/Drupal/Core/Database/Driver/mysql/Schema.php:      throw new SchemaObjectDoesNotExistException(t("Cannot rename @table to @table_new: table @table doesn't exist.", array('@table' => $table, '@table_new' => $new_name)));
./lib/Drupal/Core/Database/Driver/mysql/Schema.php:      throw new SchemaObjectExistsException(t("Cannot rename @table to @table_new: table @table_new already exists.", array('@table' => $table, '@table_new' => $new_name)));
./lib/Drupal/Core/Database/Driver/mysql/Schema.php:      throw new SchemaObjectDoesNotExistException(t("Cannot add field @table.@field: table doesn't exist.", array('@field' => $field, '@table' => $table)));
./lib/Drupal/Core/Database/Driver/mysql/Schema.php:      throw new SchemaObjectExistsException(t("Cannot add field @table.@field: field already exists.", array('@field' => $field, '@table' => $table)));
./lib/Drupal/Core/Database/Driver/mysql/Schema.php:      throw new SchemaObjectDoesNotExistException(t("Cannot set default value of field @table.@field: field doesn't exist.", array('@table' => $table, '@field' => $field)));
./lib/Drupal/Core/Database/Driver/mysql/Schema.php:      throw new SchemaObjectDoesNotExistException(t("Cannot remove default value of field @table.@field: field doesn't exist.", array('@table' => $table, '@field' => $field)));
./lib/Drupal/Core/Database/Driver/mysql/Schema.php:      throw new SchemaObjectDoesNotExistException(t("Cannot add primary key to table @table: table doesn't exist.", array('@table' => $table)));
./lib/Drupal/Core/Database/Driver/mysql/Schema.php:      throw new SchemaObjectExistsException(t("Cannot add primary key to table @table: primary key already exists.", array('@table' => $table)));
./lib/Drupal/Core/Database/Driver/mysql/Schema.php:      throw new SchemaObjectDoesNotExistException(t("Cannot add unique key @name to table @table: table doesn't exist.", array('@table' => $table, '@name' => $name)));
./lib/Drupal/Core/Database/Driver/mysql/Schema.php:      throw new SchemaObjectExistsException(t("Cannot add unique key @name to table @table: unique key already exists.", array('@table' => $table, '@name' => $name)));
./lib/Drupal/Core/Database/Driver/mysql/Schema.php:      throw new SchemaObjectDoesNotExistException(t("Cannot add index @name to table @table: table doesn't exist.", array('@table' => $table, '@name' => $name)));
./lib/Drupal/Core/Database/Driver/mysql/Schema.php:      throw new SchemaObjectExistsException(t("Cannot add index @name to table @table: index already exists.", array('@table' => $table, '@name' => $name)));
./lib/Drupal/Core/Database/Driver/mysql/Schema.php:      throw new SchemaIndexNotInSpecException(t("The index @name doesn't exist in the @table table specification.", array('@table' => $table, '@name' => $name)));
./lib/Drupal/Core/Database/Driver/mysql/Schema.php:      throw new SchemaObjectDoesNotExistException(t("Cannot add index @name to table @table: table doesn't exist.", array('@table' => $table, '@name' => $name)));
./lib/Drupal/Core/Database/Driver/mysql/Schema.php:      throw new SchemaObjectExistsException(t("Cannot add index @name to table @table: index already exists.", array('@table' => $table, '@name' => $name)));
./lib/Drupal/Core/Database/Driver/mysql/Schema.php:      throw new SchemaObjectDoesNotExistException(t("Cannot change the definition of field @table.@name: field doesn't exist.", array('@table' => $table, '@name' => $field)));
./lib/Drupal/Core/Database/Driver/mysql/Schema.php:      throw new SchemaObjectExistsException(t("Cannot rename field @table.@name to @name_new: target field already exists.", array('@table' => $table, '@name' => $field, '@name_new' => $field_new)));
./lib/Drupal/Core/Database/Driver/pgsql/Schema.php:      throw new SchemaObjectDoesNotExistException(t("Cannot rename @table to @table_new: table @table doesn't exist.", array('@table' => $table, '@table_new' => $new_name)));
./lib/Drupal/Core/Database/Driver/pgsql/Schema.php:      throw new SchemaObjectExistsException(t("Cannot rename @table to @table_new: table @table_new already exists.", array('@table' => $table, '@table_new' => $new_name)));
./lib/Drupal/Core/Database/Driver/pgsql/Schema.php:      throw new SchemaObjectDoesNotExistException(t("Cannot add field @table.@field: table doesn't exist.", array('@field' => $field, '@table' => $table)));
./lib/Drupal/Core/Database/Driver/pgsql/Schema.php:      throw new SchemaObjectExistsException(t("Cannot add field @table.@field: field already exists.", array('@field' => $field, '@table' => $table)));
./lib/Drupal/Core/Database/Driver/pgsql/Schema.php:      throw new SchemaObjectDoesNotExistException(t("Cannot set default value of field @table.@field: field doesn't exist.", array('@table' => $table, '@field' => $field)));
./lib/Drupal/Core/Database/Driver/pgsql/Schema.php:      throw new SchemaObjectDoesNotExistException(t("Cannot remove default value of field @table.@field: field doesn't exist.", array('@table' => $table, '@field' => $field)));
./lib/Drupal/Core/Database/Driver/pgsql/Schema.php:      throw new SchemaObjectDoesNotExistException(t("Cannot add primary key to table @table: table doesn't exist.", array('@table' => $table)));
./lib/Drupal/Core/Database/Driver/pgsql/Schema.php:      throw new SchemaObjectExistsException(t("Cannot add primary key to table @table: primary key already exists.", array('@table' => $table)));
./lib/Drupal/Core/Database/Driver/pgsql/Schema.php:      throw new SchemaObjectDoesNotExistException(t("Cannot add unique key @name to table @table: table doesn't exist.", array('@table' => $table, '@name' => $name)));
./lib/Drupal/Core/Database/Driver/pgsql/Schema.php:      throw new SchemaObjectExistsException(t("Cannot add unique key @name to table @table: unique key already exists.", array('@table' => $table, '@name' => $name)));
./lib/Drupal/Core/Database/Driver/pgsql/Schema.php:      throw new SchemaObjectDoesNotExistException(t("Cannot add index @name to table @table: table doesn't exist.", array('@table' => $table, '@name' => $name)));
./lib/Drupal/Core/Database/Driver/pgsql/Schema.php:      throw new SchemaObjectExistsException(t("Cannot add index @name to table @table: index already exists.", array('@table' => $table, '@name' => $name)));
./lib/Drupal/Core/Database/Driver/pgsql/Schema.php:      throw new SchemaIndexNotInSpecException(t("The index @name doesn't exist in the @table table specification.", array('@table' => $table, '@name' => $name)));
./lib/Drupal/Core/Database/Driver/pgsql/Schema.php:      throw new SchemaObjectDoesNotExistException(t("Cannot add index @name to table @table: table doesn't exist.", array('@table' => $table, '@name' => $name)));
./lib/Drupal/Core/Database/Driver/pgsql/Schema.php:      throw new SchemaObjectExistsException(t("Cannot add index @name to table @table: index already exists.", array('@table' => $table, '@name' => $name)));
./lib/Drupal/Core/Database/Driver/pgsql/Schema.php:      throw new SchemaObjectDoesNotExistException(t("Cannot change the definition of field @table.@name: field doesn't exist.", array('@table' => $table, '@name' => $field)));
./lib/Drupal/Core/Database/Driver/pgsql/Schema.php:      throw new SchemaObjectExistsException(t("Cannot rename field @table.@name to @name_new: target field already exists.", array('@table' => $table, '@name' => $field, '@name_new' => $field_new)));
./lib/Drupal/Core/Database/Driver/sqlite/Schema.php:      throw new SchemaObjectDoesNotExistException(t("Cannot rename @table to @table_new: table @table doesn't exist.", array('@table' => $table, '@table_new' => $new_name)));
./lib/Drupal/Core/Database/Driver/sqlite/Schema.php:      throw new SchemaObjectExistsException(t("Cannot rename @table to @table_new: table @table_new already exists.", array('@table' => $table, '@table_new' => $new_name)));
./lib/Drupal/Core/Database/Driver/sqlite/Schema.php:      throw new SchemaObjectDoesNotExistException(t("Cannot add field @table.@field: table doesn't exist.", array('@field' => $field, '@table' => $table)));
./lib/Drupal/Core/Database/Driver/sqlite/Schema.php:      throw new SchemaObjectExistsException(t("Cannot add field @table.@field: field already exists.", array('@field' => $field, '@table' => $table)));
./lib/Drupal/Core/Database/Driver/sqlite/Schema.php:      throw new SchemaObjectDoesNotExistException(t("Cannot change the definition of field @table.@name: field doesn't exist.", array('@table' => $table, '@name' => $field)));
./lib/Drupal/Core/Database/Driver/sqlite/Schema.php:      throw new SchemaObjectExistsException(t("Cannot rename field @table.@name to @name_new: target field already exists.", array('@table' => $table, '@name' => $field, '@name_new' => $field_new)));
./lib/Drupal/Core/Database/Driver/sqlite/Schema.php:      throw new SchemaObjectDoesNotExistException(t("Cannot add index @name to table @table: table doesn't exist.", array('@table' => $table, '@name' => $name)));
./lib/Drupal/Core/Database/Driver/sqlite/Schema.php:      throw new SchemaObjectExistsException(t("Cannot add index @name to table @table: index already exists.", array('@table' => $table, '@name' => $name)));
./lib/Drupal/Core/Database/Driver/sqlite/Schema.php:     throw new SchemaIndexNotInSpecException(t("The index @name doesn't exist in the @table table specification.", array('@table' => $table, '@name' => $name)));
./lib/Drupal/Core/Database/Driver/sqlite/Schema.php:      throw new SchemaObjectDoesNotExistException(t("Cannot add index @name to table @table: table doesn't exist.", array('@table' => $table, '@name' => $name)));
./lib/Drupal/Core/Database/Driver/sqlite/Schema.php:      throw new SchemaObjectExistsException(t("Cannot add index @name to table @table: index already exists.", array('@table' => $table, '@name' => $name)));
./lib/Drupal/Core/Database/Driver/sqlite/Schema.php:      throw new SchemaObjectDoesNotExistException(t("Cannot add unique key @name to table @table: table doesn't exist.", array('@table' => $table, '@name' => $name)));
./lib/Drupal/Core/Database/Driver/sqlite/Schema.php:      throw new SchemaObjectExistsException(t("Cannot add unique key @name to table @table: unique key already exists.", array('@table' => $table, '@name' => $name)));
./lib/Drupal/Core/Database/Driver/sqlite/Schema.php:      throw new SchemaObjectDoesNotExistException(t("Cannot add primary key to table @table: table doesn't exist.", array('@table' => $table)));
./lib/Drupal/Core/Database/Driver/sqlite/Schema.php:      throw new SchemaObjectExistsException(t("Cannot add primary key to table @table: primary key already exists.", array('@table' => $table)));
./lib/Drupal/Core/Database/Driver/sqlite/Schema.php:      throw new SchemaObjectDoesNotExistException(t("Cannot set default value of field @table.@field: field doesn't exist.", array('@table' => $table, '@field' => $field)));
./lib/Drupal/Core/Database/Driver/sqlite/Schema.php:      throw new SchemaObjectDoesNotExistException(t("Cannot remove default value of field @table.@field: field doesn't exist.", array('@table' => $table, '@field' => $field)));
./lib/Drupal/Core/Database/Install/Tasks.php:          throw new TaskException(t("Failed to run all tasks against the database server. The task %task wasn't found.", array('%task' => $task['function'])));
./lib/Drupal/Core/Database/Query/Merge.php:        throw new InvalidMergeQueryException(t('Invalid merge query: no conditions'));
./lib/Drupal/Core/Database/Schema.php:      throw new SchemaObjectExistsException(t('Table @name already exists.', array('@name' => $name)));
./lib/Drupal/Core/Template/TwigExtension.php:        throw new \Exception(t('Object of type "@class" cannot be printed.', array('@class' => get_class($arg))));
./lib/Drupal/Core/Template/TwigExtension.php:        throw new \Exception(t('Object of type "@class" cannot be printed.', array('@class' => get_class($arg))));
./lib/Drupal/Core/Theme/ThemeManager.php:      throw new \Exception(t('_theme() may not be called until all modules are loaded.'));
./lib/Drupal/Core/Updater/Updater.php:      throw new UpdaterException(t('Unable to determine the type of the source directory.'));
./lib/Drupal/Core/Updater/Updater.php:    throw new UpdaterException(t('Cannot determine the type of project.'));
./lib/Drupal/Core/Updater/Updater.php:      throw new UpdaterException(t('Unable to parse info file: %info_file.', ['%info_file' => $info_file]));
./lib/Drupal/Core/Updater/Updater.php:      throw new UpdaterException(t('Unable to parse info file: %info_file.', array('%info_file' => $info_file)));
./lib/Drupal/Core/Updater/Updater.php:        throw new UpdaterException(t('Fatal error in update, cowardly refusing to wipe out the install directory.'));
./lib/Drupal/Core/Updater/Updater.php:      throw new UpdaterFileTransferException(t('File Transfer failed, reason: !reason', array('!reason' => strtr($e->getMessage(), $e->arguments))));
./lib/Drupal/Core/Updater/Updater.php:      throw new UpdaterFileTransferException(t('File Transfer failed, reason: !reason', array('!reason' => strtr($e->getMessage(), $e->arguments))));
./modules/contextual/src/ContextualController.php:      throw new BadRequestHttpException(t('No contextual ids specified.'));
./modules/dblog/src/Plugin/rest/resource/DBLogResource.php:      throw new NotFoundHttpException(t('Log entry with ID @id was not found', array('@id' => $id)));
./modules/dblog/src/Plugin/rest/resource/DBLogResource.php:    throw new HttpException(t('No log entry ID was provided'));
./modules/field/field.api.php:      throw new \Drupal\Core\Entity\Exception\FieldStorageDefinitionUpdateForbiddenException(t('A list field (@field_name) with existing data cannot have its keys changed.', array('@field_name' => $field_storage->getName())));
./modules/field/field.purge.inc:    throw new FieldException(t('Attempt to purge a field storage @field_name that still has fields.', array('@field_name' => $field_storage->getName())));
./modules/node/node.module:      throw new Exception(t('Query tagged for node access but there is no node table, specify the base_table using meta data.'));
./modules/options/options.module:      throw new FieldStorageDefinitionUpdateForbiddenException(t('A list field (@field_name) with existing data cannot have its keys changed.', array('@field_name' => $field_storage->getName())));
./modules/rdf/rdf.module:        throw new Exception(t('Tried to map @prefix to @namespace, but @prefix is already mapped to @orig_namespace.', array('@prefix' => $prefix, '@namespace' => $namespace, '@orig_namespace' => $namespaces[$prefix])));
./modules/system/tests/modules/common_test/common_test.module:  throw new Exception(t('Uncaught exception'));
./modules/update/update.manager.inc:    throw new Exception(t('Cannot extract %file, not a valid archive.', array ('%file' => $file)));

Proposed resolution

Don't use t() in exceptions.

Also, per @dawehner:

There is a limited subset of exceptions which get t() in order to translate error message in the installer. Ideally we would have classed exceptions for all of them, so we could translate them at a more outer level.

Remaining tasks

Review patch

User interface changes

N/A

API changes

N/A

Data model changes

N/A