Hello,

There seems to be no reason why commerce coupon and commerce discount are separated. One basically requires the other and they both are related to discounts.

Therefore I propose merging commerce coupon and commerce discount into a single module, maybe with one "under" the other so if you don't want coupons you can keep it disabled or what not. This will allow us to work on a single commerce discount module, which could then be easily migrated to D8 commerce when that gets released.

Another reason is I am working on the drupal discount UI and I'd like to merge the two areas together. I think it makes more sense to have a single area called discounts. You can create a new discount with a coupon or without a coupon. But at the end of the day coupons are worthless without discounts.

Thoughts?

Comments

torgosPizza’s picture

torgosPizza
he/him
Primary language English
Location Portland, OR
CreditAttribution: torgosPizza as a volunteer commented

I disagree. It is possible to have a discount without a coupon, and a coupon is not necessarily a "discount" per se (for instance Commerce GC uses a new coupon "type" called Gift Card. Those gift card coupons essentially behave like a $ discount, utilizing a set amount, but the module does not use the Discounts engine because those coupon types require their own specialized sets of conditions and Rules).

Merging the two would probably cause development / bugfixes etc. to slow as well, as it would make an already complex module even more complex. Discount module is complex enough as it is!

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro commented
Status: Active » Closed (won't fix)

It'd make the two hard to manage. It's a win that Coupon 2.x uses Discounts, as it makes it easier to work on coupon functionality as a whole.