The Commerce Fulfillment module was created to ease the process of order fulfillment using the Drupal Commerce Module.
Allows the user to create packages and shipments, print shipping labels and packing slips, and reorgranise packages and shipments.
Project Page:
https://www.drupal.org/sandbox/gamerwamer/2507083
Git Clone:
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/Gamerwamer/2507083.git drupal_commerce_fulfillment
Drupal Version: 7.x-1.x
Reviews Done:
Comments
Comment #1
EvanSchisler CreditAttribution: EvanSchisler at Acro Commerce commentedComment #2
EvanSchisler CreditAttribution: EvanSchisler at Acro Commerce commentedComment #3
EvanSchisler CreditAttribution: EvanSchisler at Acro Commerce commentedComment #4
EvanSchisler CreditAttribution: EvanSchisler at Acro Commerce commentedComment #5
PA robot CreditAttribution: PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxGamerwamer2507083git
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #6
Vignesh Puliyadi Raja CreditAttribution: Vignesh Puliyadi Raja commentedManual Reviews:
1. Change your clone url in summary page
like : git clone --branch 7.x-1.x http://git.drupal.org/sandbox/Gamerwamer/2507083.git drupal_commerce_fulfillment
2. Found warning issues in pareview
FILE: /var/www/drupal-7-pareview/pareview_temp/commerce_fulfillment.module
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------
104 | WARNING | Variable $view is undefined.
105 | WARNING | Variable $view is undefined.
105 | WARNING | Variable $view is undefined.
--------------------------------------------------------------------------
Comment #7
EvanSchisler CreditAttribution: EvanSchisler at Acro Commerce commentedComment #8
EvanSchisler CreditAttribution: EvanSchisler at Acro Commerce commentedHere is my review done by pareview.sh
http://pareview.sh/pareview/httpgitdrupalorgsandboxgamerwamer2507083git
No errors are showing for me after addressing the $view variable.
Comment #9
EvanSchisler CreditAttribution: EvanSchisler at Acro Commerce commentedComment #10
EvanSchisler CreditAttribution: EvanSchisler at Acro Commerce commentedComment #11
EvanSchisler CreditAttribution: EvanSchisler at Acro Commerce commentedComment #12
EvanSchisler CreditAttribution: EvanSchisler at Acro Commerce commentedComment #13
EvanSchisler CreditAttribution: EvanSchisler at Acro Commerce commentedComment #14
splendidles CreditAttribution: splendidles commentedManual Review
This review uses the Project Application Review Template.
Comment #15
EvanSchisler CreditAttribution: EvanSchisler at Acro Commerce commentedPretty sure this can go to RTBC status after splendidles review?
I am going to change it.
Please let me know if I made a mistake.
Comment #16
mpdonadio@EvanSchisler, the application workflow is at https://www.drupal.org/node/532400. Someone else needs to set RTBC.
@splendidles, did you see anything to prevent RTBC on this?
Comment #17
klausimanual review:
Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.
Comment #18
EvanSchisler CreditAttribution: EvanSchisler at Acro Commerce commentedComment #19
EvanSchisler CreditAttribution: EvanSchisler at Acro Commerce commentedComment #20
EvanSchisler CreditAttribution: EvanSchisler at Acro Commerce commentedComment #21
EvanSchisler CreditAttribution: EvanSchisler at Acro Commerce commentedProject page update highlighting the differences from other Order Fulfillment modules.
Comment #22
Manjit.Singh@EvanSchisler Thanks for the Drupal contribution !! I guess
'access callback' => TRUE,
inhook_menu().
. Is that a good practice ? Because of this
shipping_label
andpacking_slip
is vulnerable.Please look into the hook_menu functions.
Comment #23
EvanSchisler CreditAttribution: EvanSchisler at Acro Commerce commentedThanks for reviewing my module @klausi and @Manjit.Singh .
I have fixed all the issues pointed out and rectified the security issue.
Setting to Needs Review.
Comment #24
klausimanual review:
Although there is quite a bit of API abuse here (especially the query functions in the templates!) those are not absolutely critical application blockers, so I think this is RTBC.
Assigning to er.pushpinderrana as he might have time to take a final look at this.
Comment #25
klausino objections for more than a week, so ...
Thanks for your contribution, EvanSchisler!
I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thanks to the dedicated reviewer(s) as well.
Comment #26
EvanSchisler CreditAttribution: EvanSchisler at Acro Commerce commentedThank you very much for all the suggestions and all the time spent by reviewers!!!