[D7]Commerce PayU India Payment Gateway

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxgaurav-bajpai2496979git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Found warning in pareview.

FILE: /var/www/drupal-7-pareview/pareview_temp/india_commerce_payu.module
-------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------
214 | WARNING | Unused variable $delta.
-------------------------------------------------------------------------

My review:

Automated Review

http://pareview.sh/pareview/httpgitdrupalorgsandboxgaurav-bajpai2496979git
It's clean!

Manual Review

 

Individual user account

 

Yes: Follows the guidelines for individual user accounts.

 

No duplication

 

No: Causes module duplication and/or fragmentation. Seems as if this payment method has already been created for Commerce.
Commerce PayU (If the India version is different than this please.)

 

Master Branch

 

Yes: Follows the guidelines for master branch.

 

Licensing

 

Yes: Follows the licensing requirements.

 

3rd party assets/code

 

Yes: Follows the guidelines for 3rd party assets/code.

 

README.txt/README.md

 

No: Does not follow the guidelines for in-project documentation and/or the README Template.
INTRODUCTION instead of SUMMARY. Also, you say there are no requirements, yet you have dependencies listed in your .info file. Those should probably be included here.

 

Code long/complex enough for review

 

Yes: Follows the guidelines for project length and complexity.

 

Secure code

 

No: Does not follow the security requirements. / No: List of security issues identified.]
You are using the $_POST variable directly at line 100 in you .module file.
You also may want to double check if you are using the placeholders in the t() function correctly. (! vs @ vs %)

 

Coding style & Drupal API usage

 

[List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:
   

1. using the same form field twice at line 255

 

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Hi Gaurav,

Your module is working fine ( Drupal 7.38 ), no issues with the payment.
And also no issues in coding standards also. Better add little more information in README.txt (suggestion).

manual review:

1. project page: what is the difference to https://www.drupal.org/project/payumoney ? Looks like the payment provider is implemented already? Please add the differences to the project page. Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition, so you should contribute to that project instead.
2. india_commerce_payu_redirect_form_validate(): most of the check_plain()s look wrong here and also the filter_input_array() since you are not printing anything to HTML which could trigger an XSS attack. Remember: only sanitize variables when you print them to HTML or other output. Make sure to read https://www.drupal.org/node/28984 again.
3. "t('There was a problem with your order: !response_code @reason_text', array('@response_code' => $status, '!reason_text' => $error_message,();": that will not work, you confused the "@" and "!" placeholders. Just use "@" always unless you are sure that you want to prevent double escaping.

But otherwise looks good to me, so ...

Thanks for your contribution, gaurav.bajpai!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.