Offering to co-maintain FileField Source [#2536240]

Hello there!

We use this module on production, but unfortunately is not very well maintained during last time. Well, i can help co-maintain project for Drupal 7 codebase.

Cheers!

Comments

Comment #1

quicksketch

he/him

CreditAttribution: quicksketch as a volunteer and at Backdrop CMS commented 6 August 2015 at 00:41

Status:

Active

» Fixed

Hi profak! That's excellent. I reviewed your module at https://www.drupal.org/sandbox/profak/2529400 and it looks great.

Just a few small guidelines from things I saw in that module:

- Be sure you use the long array syntax array(), instead of [], as many Drupal sites are still running PHP 5.3.
- Set up your editor to use 2 spaces for tabs. It looks like the module is a mix of 2 and 4 spaces. Consistency makes it easier for multiple developers to work on the project together.
- And in general, please try to be conservative with the module functionality. If you decide to greatly expand the scope of the module, please make a new branch or even a new project. "filefield" is sort of an antiquated name in any case, harking back to D6 era.

But in any case, having your help is going to do nothing but good for the module. Please reach out to me via contact form if there's anything in particular with which you need a hand. I'm not checking into my issue queues as much as I had in the past.

I've granted you full access to the project. Welcome aboard!

Comment #2

profak CreditAttribution: profak as a volunteer commented 8 August 2015 at 09:39

Hello quicksketch!

Thank you for your review!
You're right - there are still so many people using PHP 5.3 i'll fix array syntax.
Coder shows me no errors:

12:34 entity_translation_access 7.x-1.x ❯ phpcs --standard=Drupal -v *
Registering sniffs in the Drupal standard... DONE (93 sniffs registered)
Creating file list... DONE (6 files in queue)
Changing into directory /Users/prof/Code/test/sites/all/modules/entity_translation_access
Processing entity_translation_access.info [7 tokens in 7 lines]... DONE in < 1 second (0 errors, 0 warnings)
Processing entity_translation_access.install [273 tokens in 49 lines]... DONE in < 1 second (0 errors, 0 warnings)
Processing entity_translation_access.js [187 tokens in 21 lines]... DONE in < 1 second (0 errors, 0 warnings)
Processing entity_translation_access.module [2282 tokens in 319 lines]... DONE in < 1 second (0 errors, 0 warnings)
Changing into directory /Users/prof/Code/test/sites/all/modules/entity_translation_access/includes
Processing entity_translation_access.form.inc [528 tokens in 85 lines]... DONE in < 1 second (0 errors, 0 warnings)
Processing entity_translation_access.functions.inc [692 tokens in 126 lines]... DONE in < 1 second (0 errors, 0 warnings)

..but i'll check once again. Coding standards are really important - entirely agree.
About "filefield" - i'm sure i "feel" what you meant because i'm with Drupal since 2009. I was grown with Drupal 6 so i'll be conservative.

Thank you!

Comment #3

quicksketch

he/him

CreditAttribution: quicksketch as a volunteer and at Backdrop CMS commented 13 August 2015 at 07:57

Thanks @profak! Welcome again. It's great to have your help and I'm happy to see the updates. Feel free to make a new official release when you feel comfortable with the progress. As there haven't been any new releases since 2013, it'd be great to get a new one out there as soon as possible.

Comment #4

profak CreditAttribution: profak as a volunteer commented 18 August 2015 at 10:35

@quicksketch i made official release that contains most important improvements/bugfixes required by community.
Will look forward for the next release!