Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Hi,
In views_slideshow_cycle_views_slideshow_options_form_validate() the fieldname used as a key for the form_error() is not the good one so the wrong field is highlighted when the validation fails.
if (!is_numeric($form_state['values']['style_options']['views_slideshow_cycle']['timeout'])) {
form_error($form['views_slideshow_cycle']['speed'], t('!setting must be numeric!', array('timeout')));
}
should be
if (!is_numeric($form_state['values']['style_options']['views_slideshow_cycle']['timeout'])) {
form_error($form['views_slideshow_cycle']['timeout'], t('!setting must be numeric!', array('timeout')));
}
Patch to follow.
Comment | File | Size | Author |
---|---|---|---|
#1 | views_slideshow_cycle-wrong_fieldname_key-2534686-1.patch | 1.09 KB | vbouchet |
Comments
Comment #1
vbouchetComment #2
vbouchetThis has been fixed via the following commit.