Problem/Motivation

Per #2533886: [meta] Move module-specific migration support into the particular modules supported, move support for simpletest migration into the simpletest module.

Proposed resolution

For the most part, this is a matter of moving files around and updating namespaces. Also, explicit destination module dependencies can be removed.

Migration templates to be moved:

  • d6_simpletest_settings

Remaining tasks

Submit a patch.

User interface changes

N/A

API changes

Namespaces of affected migration plugins will change.

Data model changes

N/A

CommentFileSizeAuthor
#3 move_module_specific-2534026-3.patch1.45 KBmikeryan
#2 move_module_specific-2534026-2.patch5.41 KBmikeryan
#1 move_module_specific-2534026-1.patch1.29 KBmikeryan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan commented
Assigned: Unassigned » mikeryan
Status: Active » Needs review
FileSize
move_module_specific-2534026-1.patch1.29 KB
mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan commented
Status: Needs review » Needs work
FileSize
move_module_specific-2534026-2.patch5.41 KB

Fix test group, and move test to Migrate directory. Leaving at needs work, since we need some MigrateDrupal6Test work for it to pass the testbot.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan commented
FileSize
move_module_specific-2534026-3.patch1.45 KB

Cleaner patch.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan commented
Status: Needs work » Postponed

The last submitted patch, 1: move_module_specific-2534026-1.patch, failed testing.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan commented
Related issues: +#2534158: MigrateFullDrupalTestBase must use dynamic test discovery

Postponed on #2534158: MigrateFullDrupalTestBase must use dynamic test discovery.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Postponed » Needs review

Unblocked. Joy!

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Needs review » Reviewed & tested by the community

Seems legit.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed 24d3491 and pushed to 8.0.x. Thanks!

  • alexpott committed 24d3491 on 8.0.x 
    Issue #2534026 by mikeryan: Move module-specific migration support into...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.