This came up in #2458377: Upload .svg files , that if I add a mime type to one of my file types, I shouldn't have to go to /admin/config/media/file-settings and add the appropriate extension there in order to upload a file to /file/add. I think we should instead auto-generate the allowed upload extensions based on our file types.

CommentFileSizeAuthor
#14 file_entity-file_add_extensions_from_file_types-2533326-14.patch5.59 KBjoseph.olstad
#9 interdiff-2533326-8-9-do-not-test.diff1.11 KBseanB
#9 file_entity-file_add_extensions_from_file_types-2533326-9.patch5.59 KBseanB
#8 2533326-file-add-extensions-from-file-types.patch5.01 KBDave Reid
#6 2533326-file-add-extensions-from-file-types.patch4.12 KBDave Reid
#4 Selection_282.png20.31 KBDave Reid
#4 2533326-file-add-extensions-from-file-types.patch4.1 KBDave Reid
#2 Add file | drupal7.dev 2015-07-14 21-07-02.png60.02 KBDave Reid
#2 Add file | drupal7.dev 2015-07-14 21-08-07.png38.77 KBDave Reid
#2 2533326-file-add-extensions-from-file-types.patch2.97 KBDave Reid
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer commented
Related issues: +#2458377: Upload .svg files
Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer commented
Status: Active » Needs review
FileSize
2533326-file-add-extensions-from-file-types.patch2.97 KB
Add file | drupal7.dev 2015-07-14 21-08-07.png38.77 KB
Add file | drupal7.dev 2015-07-14 21-07-02.png60.02 KB

Before:

After:

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer commented
Issue tags: +Usability
Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer commented
Issue summary: View changes
FileSize
2533326-file-add-extensions-from-file-types.patch4.1 KB
Selection_282.png20.31 KB

This one changes up the default file types to be a little more restrictive and not wildcard all the audio, image, and video file types.

Updated view of file/add with the updated file types:

Status: Needs review » Needs work

The last submitted patch, 4: 2533326-file-add-extensions-from-file-types.patch, failed testing.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer commented
Status: Needs work » Needs review
FileSize
2533326-file-add-extensions-from-file-types.patch4.12 KB

Forgot to add video/mpeg to the video file type to cover the 'mpeg' extension.

Status: Needs review » Needs work

The last submitted patch, 6: 2533326-file-add-extensions-from-file-types.patch, failed testing.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer commented
Status: Needs work » Needs review
FileSize
2533326-file-add-extensions-from-file-types.patch5.01 KB

Fixed tests.

seanB’s picture

seanB
Primary language Dutch
Location Netherlands
CreditAttribution: seanB commented
FileSize
file_entity-file_add_extensions_from_file_types-2533326-9.patch5.59 KB
interdiff-2533326-8-9-do-not-test.diff1.11 KB

The patch seemed to work, but I was missing something when using the upload form in the media browser. The types added in $options['types'] were not being used. I added a check for this. Please let me know if this is something that you would consider adding.

I created this patch against the latest dev.

TwoD’s picture

TwoD
Primary language Swedish
Location Sweden
CreditAttribution: TwoD at Websystem for ComplianceOnline Ltd commented

The patch in #9 is working well for me, using it together with #2533352-1: Rethink allowed extensions on field instance to not have to think about individual extensions again!

kristofferwiklund’s picture

kristofferwiklund CreditAttribution: kristofferwiklund at Websystem commented
Status: Needs review » Reviewed & tested by the community

We have had the patch in #9 running for month now without any problems.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 9: interdiff-2533326-8-9-do-not-test.diff, failed testing.

TwoD’s picture

TwoD
Primary language Swedish
Location Sweden
CreditAttribution: TwoD at Websystem for ComplianceOnline Ltd commented
Status: Needs work » Reviewed & tested by the community

This should not have been failed...
Patch still applies cleanly.

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
FileSize
file_entity-file_add_extensions_from_file_types-2533326-14.patch5.59 KB

straightup reroll of patch 9

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
Version: 7.x-2.x-dev » 7.x-3.x-dev
Status: Reviewed & tested by the community » Fixed

this was pushed into file_entity 7.x-3.x
however, I'm testing a patch to Media to allow 7.x-2.x-dev or 7-x-3.x-dev , the requirements phase needs to check to see for 2.0 or newer but was recently preventing dev branch releases so making a change in Media to allow dev branches and newer dev branches like 7.x-3.x
if you want to test this, download file_entity 7.x-3.x dev
then Media 7.x-2.10 or newer or Media 7.x-3.0-beta4 and then apply this media patch:
#2902804-7: change file_entity requirements in Media to allow dev releases including new file_entity 3.x

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
Version: 7.x-3.x-dev » 7.x-2.x-dev
Status: Fixed » Reviewed & tested by the community

setting back to 7.x-2.x branch

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
Status: Reviewed & tested by the community » Fixed

  • 7e788de committed on 7.x-3.x 
    revert Issue#2533326 might be causing a conflict with media.

  • 7900b5d committed on 7.x-2.x 
    revert Issue#2533326 might be causing a conflict with media.
joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
Status: Fixed » Needs work

I reverted this change as it appears to cause problems with the media module tests for media_internet.

  • 7900b5d committed on 7.x-3.x 
    revert Issue#2533326 might be causing a conflict with media.
joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented

this patch conflicts with media_internet (causes failures in the media_internet tests) , a sub module of media, before committing this patch, make sure to run the full media tests in the testing tool.