Modal display is entirely broken [#2532686]

Problem/Motivation

When you click on select entities for the field files(modal example) from the content type entity_browser_test, a modal window is supposed to open. But it doesn't.

Proposed resolution

When I do an inspect element I can see that the url is entity-browser/modal/test_files1?uuid=c4b664e8-d8c1-4535-9709-9be37ea035f8&original_path=/node/add/entity_browser_test and opening that in a different page shows the file browser properly. So I am thinking this has something to do with javascript or the properties passed to the anchor tag which needs to be fixed.

Remaining tasks

- write patch
- review patch

Comments

Comment #1

gokulnk CreditAttribution: gokulnk at Azri Solutions for CyberSafe commented 14 July 2015 at 06:50

Title:

Files browser modal display form examples is not working

» Files browser modal display from examples is not working

Comment #2

slashrsm CreditAttribution: slashrsm at Examiner.com commented 14 July 2015 at 18:07

Title:

Files browser modal display from examples is not working

» Modal display is entirely broken

This a bigger problem. Modal display is entirely broken. I suspect this was caused by some changes in core at some point. Yesterday I spent some time to figure out the solution but was not very successful....

Comment #3

slashrsm CreditAttribution: slashrsm at Examiner.com commented 14 July 2015 at 18:07

Issue tags:

+Media Initiative, +D8Media

Comment #4

jonhattan

Spanish

Plasencia

CreditAttribution: jonhattan commented 2 August 2015 at 10:51

Status:

Needs work

» Needs review

PR: https://github.com/drupal-media/entity_browser/pull/80

Comment #5

slashrsm CreditAttribution: slashrsm at Examiner.com commented 3 August 2015 at 13:26

Status:

Needs review

» Fixed

Merged. Thanks!

Comment #6

gokulnk CreditAttribution: gokulnk at Azri Solutions for CyberSafe commented 4 August 2015 at 06:06

I can confirm that the fix is working.

I wish there was a mechanism using which the maintainers would get a notification when there is a change record that relates to code in the module. It would have made life much easier ;)