Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
after fresh install
table advagg_files
column content_hash - differences on: not null, default
declared: array('description' => 'TODO: please describe this field!', 'type' => 'char', 'length' => 43, 'not null' => TRUE, 'default' => '')
actual: array('description' => 'TODO: please describe this field!', 'type' => 'char', 'length' => '43', 'not null' => FALSE)
Comment | File | Size | Author |
---|---|---|---|
#11 | advagg-2531766-10-fix-install.patch | 3.82 KB | mikeytown2 |
#8 | advagg-2531766-8-fix-db-schema.patch | 5.81 KB | mikeytown2 |
Comments
Comment #1
mikeytown2 CreditAttribution: mikeytown2 commentedThat doesn't match what is in the code http://cgit.drupalcode.org/advagg/tree/advagg.install#n131
There is no TODO anywhere. Help me understand what's wrong. What did you use to get your information and what type of SQL server do you have.
Comment #2
jabecz CreditAttribution: jabecz commentedI have just reproduced the issue at
https://depf.ply.st/node#overlay=admin/structure/schema
but I am not able to debug what code creates mismatching column with "TODO ...." description.
there is no "TODO ...." stuff in advagg.install as you mentioned.
Comment #3
mikeytown2 CreditAttribution: mikeytown2 commentedhttps://www.drupal.org/project/schema is the module in question; I'll take a look at it tomorrow
Comment #4
jabecz CreditAttribution: jabecz commentedComment #5
jabecz CreditAttribution: jabecz commentedI have just installed "Advagg" with no "Schema" module and the content_hash column is "NULL : YES".
Comment #6
mikeytown2 CreditAttribution: mikeytown2 commentedMissing descriptions has to do with the way the schema module is used.
Inside the schema_compare function it calls drupal_get_schema this then calls drupal_get_complete_schema which then calls _drupal_schema_initialize which removes the description from every entry.
In order for the schema module to actually work correctly it would need to implement it's own version of drupal_get_complete_schema() that calls _drupal_schema_initialize($schema, $module, $remove_descriptions) where $remove_descriptions is set to FALSE. This is a bug in the schema module.
Comment #7
mikeytown2 CreditAttribution: mikeytown2 commentedRoot of this issue is the advagg_install_change_table_collation function.
Comment #8
mikeytown2 CreditAttribution: mikeytown2 commentedComment #11
mikeytown2 CreditAttribution: mikeytown2 commented