Currently in references_dialog_entityreference_link_helper() $label is being passed into t('Create @type', array('@type' => $label)) with the "@" which causes $label to run through check_plain() twice since the $label received from from entityInfo() has already been translated (which also runs through check_plain()).

Example:
With "@": "It's a content type label"
With "!": "It's a content type label"

CommentFileSizeAuthor
#2 references_dialog-fix_label_double_escaping-2530692-2.patch800 bytesmaximpodorov
#1 2530692-0-reference_dialog-double_escaped_label.patch532 bytesgrndlvl
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

grndlvl’s picture

grndlvl CreditAttribution: grndlvl commented
FileSize
2530692-0-reference_dialog-double_escaped_label.patch532 bytes
maximpodorov’s picture

maximpodorov CreditAttribution: maximpodorov commented
Status: Active » Needs review
FileSize
references_dialog-fix_label_double_escaping-2530692-2.patch800 bytes

An alternating solution is to mark links as containing HTML titles.

Status: Needs review » Needs work

The last submitted patch, 2: references_dialog-fix_label_double_escaping-2530692-2.patch, failed testing.

The last submitted patch, 2: references_dialog-fix_label_double_escaping-2530692-2.patch, failed testing.