Add tid to code [#2529526]

When adding a taxonomy term index to the Search API I get the following error:

SearchApiException: The 'objectID' attribute is required to use action=updateObject near line:1 column:113 inSearchApiAlgoliaService->indexItems() (line 168 of public_html/sites/all/modules/search_api_algolia/includes/service.inc).

Briefly looking in the code I only see mention of the 'nid' in reference to the objectID that algolia is needing. Would it be hard to add 'tid' to the code so I can use a taxonomy index?

Comments

Comment #1

hankpalan.com CreditAttribution: hankpalan.com commented 8 July 2015 at 21:15

Issue summary:

View changes

Comment #2

mlbrgl CreditAttribution: mlbrgl as a volunteer commented 15 July 2015 at 21:07

Hi Hank,

At the moment, I have been working with node and user entities, but the module published on d.o is only focusing on node entities (and as you rightfully noticed, this choice is hardcoded). When I have to switch to user entities, I pretty much replace 'nid' with 'uid' for now, but this situation quickly shows its limit when you want to index both node and user entities on the same site. Making this more generic is definitely on my roadmap, as several people have been asking for it. If you have an immediate need for indexing taxonomy terms, I would suggest you play with replacing 'nid' with 'tid' on line 131. But please keep in mind this has not been tested.

Matthieu

Comment #3

16 July 2015 at 18:04

mlbrgl committed 3d8fd83 on 7.x-1.x

Issue #2529526 by mlbrgl: Add tid to code
Added support for generic...

Comment #4

mlbrgl CreditAttribution: mlbrgl as a volunteer commented 16 July 2015 at 18:14

Assigned:	Unassigned	» mlbrgl
Status:	Active	» Needs review

Generic entity-based indexes are now supported. Tests have been carried out on nodes, users and taxonomy terms but any entity should work.

Comment #5

hankpalan.com CreditAttribution: hankpalan.com commented 17 July 2015 at 00:49

I just updated the service.inc and it seems to be working correctly. I'll run it through a few things over the next week and get back to you with any problems.

Thanks for doing this!