There is still some performance optimization that should be done in hook_preprocess_page() particularly around the calls to menu_tree_build which are very expensive.

This issue was reported in the 1.x branch and it was recommended to use render caching.

See @ https://drupalwatchdog.com/volume-4/issue-1/automagic-speed-cache

CommentFileSizeAuthor
#3 additional_caching_for-2527832-2.patch2.93 KBsylus
#1 additional_caching_for-2527832-1.patch2.94 KBsylus
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sylus’s picture

sylus CreditAttribution: sylus commented
FileSize
additional_caching_for-2527832-1.patch2.94 KB

Looks like this will shave up to 200ms for the average page load and reduce the wall time and memory by 5%.

sylus’s picture

sylus CreditAttribution: sylus commented

Removed extraneous call to drupal_render.

sylus’s picture

sylus CreditAttribution: sylus commented
FileSize
additional_caching_for-2527832-2.patch2.93 KB
natew’s picture

natew CreditAttribution: natew commented

This seems reasonable to me. :)

sylus’s picture

sylus CreditAttribution: sylus commented
Status: Active » Reviewed & tested by the community
sylus’s picture

sylus CreditAttribution: sylus commented
Component: Code » WetKit Bootstrap
Status: Reviewed & tested by the community » Fixed
sylus’s picture

sylus CreditAttribution: sylus commented

I added another render cache for the custom search form which calls drupal_get_form and is rather expensive.

  • sylus committed 07755b3 on 7.x-4.x 
    Fixed WetKit Bootstrap for Issue #2527832 by sylus: Additional caching...
  • sylus committed 3d36e18 on 7.x-4.x
    Fixed WetKit Test for Remove check for active-trail as conflicts with...
  • sylus committed 4f19cfe on 7.x-4.x
    Fixed WetKit Bootstrap for Issue #2527832 by sylus: Additional caching...
  • sylus committed 6673a57 on 7.x-4.x
    Fixed WetKit Bootstrap for Issue #2527832 by sylus: Additional caching...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.