Follow-up to #2502785: Remove support for $form_state->setCached() for GET requests

Problem/Motivation

#2502785: Remove support for $form_state->setCached() for GET requests split the removal of #ajax url out to another issue.

Proposed resolution

- Incorporate #2502785-70: Remove support for $form_state->setCached() for GET requests back here or #2502785-73: Remove support for $form_state->setCached() for GET requests

Remaining tasks

- Discuss
- Do it

User interface changes

- None

API changes

TBD

Data model changes

TBD

BETA EVAL:

Potentially prioritized change as direct follow-up to a critical.

Files: 
CommentFileSizeAuthor
#3 2527740-url-3.patch14.74 KBtim.plunkett

Comments

Fabianx’s picture

Title: Consider to remove support for Remove support for #ajax['url'] » Consider to remove support for #ajax['url']
catch’s picture

Also even if we don't do this, we could still do the Views change?

tim.plunkett’s picture

FileSize
14.74 KB

Here's that portion of the patch from the other issue. Will fail a bit.

We could remove all non-test usages of it, even if we choose not to remove the functionality.

Either way we should add support for '#ajax' => TRUE.

dawehner’s picture

Either way we should add support for '#ajax' => TRUE.

Agreed on that.

Personally I think #ajax][url is fine, given that the main problem of the other issue was form cache, but this is not needed, for all of the examples, we have.

Wim Leers’s picture

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.