SafeMarkup::checkPlain() always escapes and sets safe. SafeMarkup::escape() only escapes if the string if not already marked as safe. This is causing confusion. At least, the functions need to be better documented.

This is plenty of discussion about this #2506195: Remove SafeMarkup::set() from Xss::filter()

Comments

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Issue summary: View changes
Related issues: +#2506195: Remove SafeMarkup::set() from Xss::filter()
joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented
Status: Active » Closed (duplicate)

SafeMarkup::escape doesn't exist any more. Closing as duplicate.