I'd like to add Japanese phone number into this module.

CommentFileSizeAuthor
#4 interdiff-2526154-3-4.txt692 byteshgoto
#4 phone-japan-phone-number-2526154-4.patch7.02 KBhgoto
#3 phone-japan-phone-number-2526154-3.patch7.02 KBhamrant
#3 interdiff-2526154-2-3.txt4.47 KBhamrant
#2 phone-japan-phone-number-2526154-2.patch6.25 KBhgoto
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hgoto’s picture

hgoto CreditAttribution: hgoto as a volunteer commented

I created a patch. This includes:

- Japanese phone number rule
- test for Japanese phone number
- corresponding document

hgoto’s picture

hgoto CreditAttribution: hgoto as a volunteer commented
FileSize
phone-japan-phone-number-2526154-2.patch6.25 KB
hamrant’s picture

hamrant CreditAttribution: hamrant at DEWEB Studio for Drupal Ukraine Community commented
FileSize
interdiff-2526154-2-3.txt4.47 KB
phone-japan-phone-number-2526154-3.patch7.02 KB

Looks great, but you forgot to add Japan to the list of countries in phone_countries function. I fixed this. Also corrected the drupal coding standards.

hgoto’s picture

hgoto CreditAttribution: hgoto as a volunteer commented
FileSize
phone-japan-phone-number-2526154-4.patch7.02 KB
interdiff-2526154-3-4.txt692 bytes

@hamrant, thank you for checking and improving the patch. Your patch looks good. I found a few typo and fixed them. Thank you.

hgoto’s picture

hgoto CreditAttribution: hgoto as a volunteer commented