Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
ViewsUiConverter upcasts a config entity based on the current session.
While this only happens on views admin pages, it's a bad pattern to randomly change config or content entities in paramconverters.
Proposed resolution
Do this somewhere else, probably in the controller(s).
Remaining tasks
Fix the bugs
Remove the proxy class
Celebrate
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#9 | 2524334-9.patch | 11.9 KB | dawehner |
#9 | interdiff.txt | 1.12 KB | dawehner |
#6 | interdiff.txt | 1.01 KB | dawehner |
#6 | 2524334-6.patch | 41.41 KB | dawehner |
#4 | interdiff.txt | 466 bytes | dawehner |
Comments
Comment #1
dawehnerYeah I'm totally fine with that. To be clear I always thought it was kinda a hack, what we are doing there.
Comment #2
dawehnerLet's see ... Maybe this is all we need.
Comment #4
dawehnerMaybe that is all already.
Comment #6
dawehnerMh?
Comment #7
Wim LeersThis patch includes the patch at #2443323: New convention: CacheContextInterface implementations should mention their ID in their class-level docblock :) Let's remove that :P
Comment #9
dawehnerLet's see.
Comment #11
dawehner