Don't show crop for video or documents [#2521962]

I'm using a File field with the Media Browser widget along with ManualCrop. Works great when I add an image to my field. But when adding a Video I get the error "It appears that some of the images could not be loaded for cropping, please try again in another browser." when I try to edit the node.

I don't know if it's trying to crop the preview images (this is with media_vimeo). But I'd like some options for controller which file type the manualcrop is shown for.

To fix this in Open Atrium, I'm going to add a patch to restrict manualcrop to just "image" file types. There is probably a better way to handle this but I defer to the module maintainer for that. For now I just need to fix the errors people are getting in Atrium when adding videos.

Comment	File	Size	Author
#1	manualcrop_dont_show_crop_for_video-2521962-1.patch	748 bytes	mpotter

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

mpotter CreditAttribution: mpotter commented 2 July 2015 at 17:43

Status:

Active

» Needs review

File	Size
manualcrop_dont_show_crop_for_video-2521962-1.patch	748 bytes

Here is the patch

Comment #2

Tess Bakker

they/them

Dutch

CreditAttribution: Tess Bakker at ezCompany commented 2 July 2015 at 19:15

Status:	Needs review	» Needs work
Related issues:		+#2161875: ManualCrop not working for other image file types

Hi mpotter,

Could you re-create this patch and look for the manualcrop setting with the entity type and/or field instance?

In this way you can create other file entities with image properties and not solely rely on the 'image' file entity.

Here is a simple use case. You can create a 'avatar' file entity with image properties and a specific manualcrop setting. When selecting a new avatar, you can choose from other avatar images in your Media library or upload a new one. On the same page you can upload a 'cover' file entity with a lot more image properties and no manualcrop.

If you like to see more of this look at #2161875: ManualCrop not working for other image file types