When webform_email_html_capable is doing its checks for HTML enabled email systems, it loops through a whitelist of known systems. But even if it finds an acceptable system (in my case mimemail) , it can keep going and can end up returning FALSE if the last iteration doesn't turn up trumps.

This 2-line patch fixes that.

I found this issue when attempting to get MimeMail to bring HTML Email goodness to Webform. When I selected MimeMail at admin/config/system/mailsystem the 'send as HTML' buttons never appeared on webform email config screens.

CommentFileSizeAuthor
#3 2521736_webform_mailsystems_check_enable_fix-3.patch844 bytesSpokje
webform_mailsystems_check_enable_fix.patch1.31 KBanthonylindsay
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

anthonylindsay’s picture

anthonylindsay CreditAttribution: anthonylindsay commented
Issue summary: View changes
DanChadwick’s picture

DanChadwick CreditAttribution: DanChadwick commented
Status: Active » Closed (won't fix)

The 7.x-3.x branch is receiving only critical bug fixed, plus the branch maintainer's whim. torotil may commit this patch.

This bug doesn't exist in the 7.x-4.x branch because the white list approach has been eliminated in preference to a configuration option.

Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje at Annertech commented
FileSize
2521736_webform_mailsystems_check_enable_fix-3.patch844 bytes

For the (unfortunate) few still stuck on 7.x-3.x, here's a re-roll against the latest incarnation of that branch.