Add realname property getter callback to user entity

1. +++ b/realname.module
   @@ -433,3 +433,23 @@ function realname_username_raw_token_validate(&$element, &$form_state) {
   +    'getter callback' => 'realname_getter_callback',
   

   Me thinks this can just use entity_property_verbatim_get.

2. +++ b/realname.module
   @@ -433,3 +433,23 @@ function realname_username_raw_token_validate(&$element, &$form_state) {
   \ No newline at end of file
   

   Nit: Missing trailing new line.

+1 on #3
With a visual review, everything looks good. But I haven't actually tested the module with entity api either.

Had a chance to test #3 against a commons site. It works fine.

function realname_entity_property_info_alter(&$info) {
$properties = &$info['user']['properties'];

$properties['realname'] = array(
'label' => t("Realname"),
'description' => t("The Realname of User."),
'type' => 'text',
'getter callback' => 'entity_property_verbatim_get',
);
}

re #7: Is that a +1 on RTBC or some other type of feedback?

I have no idea how this works. Can you add tests, please?

Maybe the thing you really need is user's entity label rather than the realname, just instead use wrapper->label(), as $wrapper->label() will take into account the realname.

But If you update the user then reload the user, its label does not change as the 'realname_load_multiple' cache not updated,
see #2620882: Reset realname cache for the updated user

I made some changes in the code because I had some problems with the entity module. I listed the errors below:

Notice: Undefined index: label in entity_views_field_definition() (line 191 of /modules/contrib/entity/views/entity.views.inc).
Notice: Undefined index: label in entity_token_token_info_alter() (line 93 of /modules/contrib/entity/entity_token.tokens.inc).

Patch #11 worked fine without the mentioned errors.

+1 RTBC

Still needs tests.

Why not instead use $user_wrapper->label()? label() returns the realname value.

#11 worked great. In my use-case I had to index the realname in a Search API index. This patch made that possible. Thank you!

@edwardaa
You are right, using ->label() works because of :)

However, there may be some cases where the label() is also modified by other modules and a developer may want to access what realname generates instead.

@hass
What kind of tests are you thinking of?

Stupid question but is this supposed to add [realname] as a field to the entity type user?

[base table field types] => Array
(
[uid] => int
[name] => varchar
[pass] => varchar
[mail] => varchar
[theme] => varchar
[signature] => varchar
[signature_format] => varchar
[created] => int
[access] => int
[login] => int
[status] => int
[timezone] => varchar
[language] => varchar
[picture] => int
[init] => varchar
[data] => blob
)