fb_likebox.js uses en_EN as fixed language parameter for js.src.

Site admins need to be able to configure this if the sites language is other than English.

Related issue #2499463: Invalid App Id patch #9 makes fb_likebox.js file configurable.

CommentFileSizeAuthor
#7 fb_likebox-language_configurable-2511928-3.patch6.51 KBsilkogelman
#6 fb_likebox-language_configurable-2511928.patch6.39 KBdrozas
#5 fb_likebox.zip3.85 KBHuelfe
#1 drupal-facebook-page-plugin-language-configurable.png30 KBsilkogelman
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

silkogelman’s picture

silkogelman CreditAttribution: silkogelman commented
FileSize
drupal-facebook-page-plugin-language-configurable.png30 KB

P.S.
I'm happy to create a patch for this when a final version of #2499463: Invalid App Id is committed.

I made a proof of concept already, so a patch is not that much work for me (or anyone else for that matter).
Drupal Facebook page plugin with configurable language

silkogelman’s picture

silkogelman CreditAttribution: silkogelman commented

Facebooks official documentation about this:
https://developers.facebook.com/docs/plugins/page-plugin#settings

baekelandt’s picture

baekelandt CreditAttribution: baekelandt as a volunteer commented

Hello Silkogelman, I committed the final version of #2499463: Invalid App Id are you still willing to provide a patch for the language issue (and for #2512556: Allow all page plugin settings to be configurable by user if you have enough time)? I don't think I'll have enough time to create one myself.

silkogelman’s picture

silkogelman CreditAttribution: silkogelman commented

I am, I'll post patches for both issues next week.

Huelfe’s picture

Huelfe CreditAttribution: Huelfe commented
FileSize
fb_likebox.zip3.85 KB

In the zip file are the changes to choose a different language. Sorry for not creating a patch file, but for some reasons i had no time for it. I hope it will help! :)

drozas’s picture

drozas CreditAttribution: drozas as a volunteer commented
Status: Active » Needs review
Issue tags: +dcnorth15
FileSize
fb_likebox-language_configurable-2511928.patch6.39 KB

Thanks @Huelfe,

I have created a patch based on the .zip file that you submitted. Could you please verify that all the changes you suggested are included?

Thanks!

silkogelman’s picture

silkogelman CreditAttribution: silkogelman as a volunteer commented
FileSize
fb_likebox-language_configurable-2511928-3.patch6.51 KB

Tested and updated the patch a bit: the code from #5 works, but there was an array structure mistake in the patch from #6.

This updated patch should do the trick.

P.S.
Sorry for not letting you guys know I did not find the time to create a patch earlier as I described in #4.
I created a patch for #2512556: Allow all page plugin settings to be configurable by user but at that moment I didn't have the time for creating a patch for the current issue.

Huelfe’s picture

Huelfe CreditAttribution: Huelfe commented

The patch from #7 looks good. Maybe the language array should be translatable?

silkogelman’s picture

silkogelman CreditAttribution: silkogelman as a volunteer commented

I like the idea, and I'm happy to update the patch with t() wrappers.

And would it be nice if the list was ordered alphabetically?
It makes it easier for people to find their language.

Another bonus feature could be to create a select box that says 'autoselect users language' to enable an autoselect option that detects the users language.
That may be input for another issue though :)

Huelfe’s picture

Huelfe CreditAttribution: Huelfe commented

Autoselect users language is a interesting feature! But you're right, this is another issue.

I agree with you. An alphabetically sorted array makes much more sense. Just make sure to sort the translated strings and not the default ones. :)

silkogelman’s picture

silkogelman CreditAttribution: silkogelman as a volunteer commented
Related issues: +#2541836: Translatable languages list , +#2541840: Order the language list alphabetically, +#2541844: Autoselect user language

To have the current issue available for end-users as quickly as possible I suggest we test & commit the patch from #7 asap.

I created new issues for the other ideas:
#2541836: Translatable languages list
#2541840: Order the language list alphabetically
#2541844: Autoselect user language

szecsodimlaszlo’s picture

szecsodimlaszlo CreditAttribution: szecsodimlaszlo commented

I can confirm that the patch from #7 is working.
Thank you.

baekelandt’s picture

baekelandt CreditAttribution: baekelandt as a volunteer commented

Committed patch #7 and placed t() functions around the languages as suggested in #8 and #9 (see issue #2541836: Translatable languages list )

baekelandt’s picture

baekelandt CreditAttribution: baekelandt as a volunteer commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.