This project is a fork of a commercial set of modules called MoneyScripts. The project page explains the whole story. The aim of this set of modules is to provide some powerfull methods for making money with Drupal, like a membership system, an affiliates system, a pay per view system, etc.

There is no set of modules offering this complete set of applications. There are some modules for managing affiliates, or for making premium content, but this set of modules offers an integrated solution for a big set of applications aimed ad money making.

The project page is: https://www.drupal.org/sandbox/farreres/2490484

The git clone command is: git clone --branch 7.x-10.x-dev http://git.drupal.org/sandbox/Farreres/2490484.git moneysuite

Manual reviews of other projects

  1. https://www.drupal.org/node/2514954#comment-10074106
  2. https://www.drupal.org/node/2511268#comment-10074122
  3. https://www.drupal.org/node/2486429#comment-10074142
  4. https://www.drupal.org/node/2515452#comment-10077872
  5. https://www.drupal.org/node/2522658#comment-10081664
  6. https://www.drupal.org/node/2522102#comment-10081674

Comments

PA robot’s picture

Status: Needs review » Needs work

Timeout when invoking pareview.sh for http://git.drupal.org/sandbox/Farreres/2490484.git at http://pareview.sh/pareview/httpgitdrupalorgsandboxFarreres2490484git

Do you have any third-party files committed? 3rd party code is not generally allowed on Drupal.org and should be deleted. This policy is described in the getting involved handbook. It also appears in the terms and conditions you agreed to when you signed up for Git access.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

kamescg’s picture

Status: Needs work » Needs review

Hello Farreres,

The module since it's it being forked from an existing (commercial) module needs to be cleaned up a bit.

First, remove the Drupal version numbers and package name in the Module .info files.

Second, delete the CVS $ID tags in the modules files.

http://pareview.sh/pareview/httpgitdrupalorgsandboxfarreres2490484git

Best of luck on getting the project approved and maintaining support for the module.

Farreres’s picture

Status: Needs review » Needs work

I have done all the modifications. Modified branch name, removed version and project from .info files and removed $ID from files. Let's see if there are more things to be done.

Farreres’s picture

Pareview tells me:

It appears you are working in the "7.x-10.x" branch in git.

But I have followed the instructions for moving from master to a version branch. Although it seems the result is not what was expected. Any help on this?

Farreres’s picture

Issue summary: View changes
Farreres’s picture

Issue summary: View changes
Farreres’s picture

Issue tags: +PAreview: review bonus
Farreres’s picture

Status: Needs work » Needs review
Farreres’s picture

Issue summary: View changes
fugazi’s picture

Hello,

I would like to mention that I think it's really great that now is this modules under active maintainer. Respect!

I have the modules now looked at times and it runs on my test system stable. No Mistakes.

I had used for a customer project Drupal Commerce, but will take on another customer project, Money Suite shortlisted. Here I like very pay per view and Membership suite. Especially for customers easy to manage.

I hope the Money Suite gets the attention that may come out of the sandbox it soon.

RachelNY’s picture

First, a thank you to Farreres for taking on the task of maintaining these modules.

It should be noted that the MoneySuite modules are a fork of a pre-existing set of modules for which many of us had been paying for support and upgrades (the original developer became non-responsive, so many of us have not renewed). I mention this for an important reason - I have been using these modules on several sites, for over 3 years, and they have been tested in development and production environments. This is not some new untested idea - these modules are an excellent set of tools that have been around for years and will be incredibly useful to the community.

To the best of my knowledge, there is no other out-of-the-box, end-to-end solution similar to what MoneySuite provides.

We have installed the MoneySuite fork on our development server and have seen no difference in the effectiveness and stability of the modules.

I would encourage whomever is responsible for approving modules to fast-track this and get it online as soon as possible. There are many members of the community who are relying on the these modules, in a production environment, and now have no support and no upgrade path.

Approving this fork will resolve these problems.

Thank you,
Rachel

Farreres’s picture

Issue summary: View changes
Farreres’s picture

Issue summary: View changes
Farreres’s picture

Issue summary: View changes
dilipsingh02’s picture

Status: Needs review » Needs work

I have try to clone project using http://pareview.sh/pareviewget error.

Git clone failed. Aborting.

Farreres’s picture

Status: Needs work » Needs review

I don't understand the error you say, there is no such url http://pareview.sh/pareviewget sorry

To clone you should use git clone command in my first message....

RachelNY’s picture

We have been able to clone the project multiple times with no issues using the supplied standard git clone command and the git gui.

RachelNY’s picture

Status: Needs review » Reviewed & tested by the community
RachelNY’s picture

Extensive testing completed in multiple development environments.

We've been using this code for over 3 years... looking forward to being able to work with the community so we can support it ourselves...

njwrigley’s picture

I can confirm that I have used (what was) Membership Suite for the last 3 years with zero errors. For what it's worth.

stewest’s picture

I'd love to see a Drupal 6 version, for slightly legacy support (as this is the version my client is currently using. We had to renew the license last week but only read this thread now).

The modules used to work very well, and were extremely easy to set up. So looking forward to this community version.

RachelNY’s picture

MoneySuite has now been fully tested in multiple dev environments and was moved, 2 days ago, into production with no issues.

cweagans’s picture

Status: Reviewed & tested by the community » Fixed

I would encourage you to get the original maintainer to help collaborate on this project (collaboration over competition!). However, that's not related to whether or not this application can move forward, which, IMO, it can.

Thanks for your contribution!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Farreres’s picture

@cweagans Thanks! That was fast! We are very happy to move forward in this group effort. I agree with you about the idea of collaboration over competition, but the original developer is not answering any of the emails that are sent to him. I don't find how in the world we could bring him here.

klausi’s picture

If you can't reach a maintainer you can follow the abandoned project process to take over any existing project: https://www.drupal.org/node/251466

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

kamescg’s picture

@Farreres Will you be the developer/maintainer for the project?

Farreres’s picture

@kamescg: I am doing it for the moment, but others are invited to join. It's a big set of utilities and a lot of code to maintain.

kamescg’s picture

@Farreres I would be happy to help with support/tickets/issues. I'm currently working on updating and enhancing the Amazon Module. MoneySuite and the Amazon Module/Store could be a great combination for a variety of entrepreneurial Drupal website/application.

Have you thought about doing active development on a GitHub repository for such a large code-base?

Farreres’s picture

@kamescg If you want I can add you as maintainer

kamescg’s picture

What are the short/long term goals for the project? It's a big project, so I am hesitant :) to slap maintainer label on, but I would be happy to get aquatinted with the code to see where I can best contribute.

How big is the current community of active module users?

Farreres’s picture

As you say, it's a big project. The short term goal is to have a first stable release. This will be accomplished by testing all submodules. Minimal code modifications have been done in this first step but some bugs could be caused. We all need to get acquainted to the code, it's a huge amount of code and many different applications. The community of users is as big as moneyscripts community, but we are just launching the project, so we need to build trust within the community.

I will add you as maintainer right away.

kamescg’s picture

I have created a GitHub repository and Slack channel. Like I said before, I don't think these channels should replace Drupal issues and module downloads, but should be used for developers to collaborate. It's a big project, so separating the channels should hopefully prove to be worthwhile.

My goal over the next couple of weeks is investigate problems in the issue - As I start to understand the code more I'll be starting adding comments and worthwhile notes to the code.

Slack Channel: moneysuite.slack.com
GitHub Repository: https://github.com/KamesCG/MoneySuite

Farreres’s picture

Well, I am confortable working with drupal git from my giteye or my linux. I don't know about slack.

kamescg’s picture

How I best understand Slack's potential for Open Source Collaboration is for example organizing contributors/maintainers every other Wednesday 8:00am AM to update each other about the work being done and we can help each other. Slack is a basically chat-room, but with work related features.

The idea is to ease development cycles by connecting regularly and creating tasks we can tackle together at a maintainable pace.