Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
The field configuration form used to have the id "field_ui_field_instance_edit_form", and at some point (I believe as part of #2448503: Convert the "Field edit" form to an actual entity form) the id is now "field_config_edit_form" and the form structure is a bit different.
This patch makes the form alter work again. There is still an issue that keeps the token browser from showing up, but at least adding tokens works.
Comment | File | Size | Author |
---|---|---|---|
#8 | field_configuration-2511324-8.patch | 4.05 KB | hussainweb |
| |||
#8 | field_configuration-2511324-8-tests-only-fail.patch | 1.65 KB | hussainweb |
Comments
Comment #1
floretan CreditAttribution: floretan at Wunder commented$field->isLocked() doesn't exist anymore, and I'm not sure it's needed in this place anymore.
Comment #2
floretan CreditAttribution: floretan at Wunder commentedOops, wrong patch
Comment #3
couturier CreditAttribution: couturier as a volunteer commentedfloretan, do you have update on the status of this issue? The official D8 release is here, and the Token module is moving fast toward an official 8.x release as well.
Comment #4
BerdirWill check this when the tests are passing again, automated tests would be great.
Comment #5
askibinski CreditAttribution: askibinski at Merge commentedPatch at #5 does return the "browse available tokens" in my admin screen, and it works although the dialog pops up in the bottom right corner and seems to have minor styling issues.
Curiously though, if I browse the tokens at the default core user picture field at:
admin/config/people/accounts/fields/user.user.user_picture
I'm not able to find the tokens which are used default as value for the map value:
pictures/[date:custom:Y]-[date:custom:m]
But that's probably a different issue.
Comment #6
hussainwebI am bringing over the patch from #2639132: Token Browser does not appear on Field edit form which is very identical to the patch in #2 except for two things.
Thanks for this. I didn't find this issue when I searched earlier or else I would have worked off this patch.
Comment #7
hussainwebComment #8
hussainwebHere is a test only and with tests patch. The test worked with fix on my local. I didn't try it without fix. Let's see what happens.
Comment #10
BerdirAwesome, thanks for writing a test!