Problem/Motivation

CommentLazyBuilders class constructor use Renderer instead of RendererInterface, adding faulty dependency to Renderer class.

Proposed resolution

CommentLazyBuilders class constructor should be changed to use the RendererInterface

User interface changes

none

API changes

none

Data model changes

none

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug, because other implementations of Renderer won't be possible
Issue priority Normal, because the impact is not that high
Disruption No disruption
CommentFileSizeAuthor
#1 faulty_dependency_to-2509650-1.patch1.79 KBwillzyx
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

willzyx’s picture

willzyx CreditAttribution: willzyx commented
FileSize
faulty_dependency_to-2509650-1.patch1.79 KB
willzyx’s picture

willzyx CreditAttribution: willzyx commented
Issue tags: +Faulty dependencies

tagging, so it is much easier to find these issues

willzyx’s picture

willzyx CreditAttribution: willzyx commented
Issue summary: View changes

Added beta evaluation

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quick fix

Looks good to me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Nice find. Committed 55d056d and pushed to 8.0.x. Thanks!

  • alexpott committed 55d056d on 8.0.x 
    Issue #2509650 by willzyx: Faulty dependency to Renderer in Drupal\...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.