I'm thinking of using this module for one of my projects. Don't know if its gonna make it, but I needed some extra functionality and I coded it in the two following commits/patches.

Please check them and if you like/approve them merge them :)

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bserem’s picture

bserem’s picture

bserem’s picture

Status: Active » Needs review
rcodina’s picture

Thanks @bserem. I will check this out ASAP. I like the idea of having the option to choose between blacklist or whitelist. However, I don't see why users would want to have this module enabled on non admin pages.

Once said that, I don't like the idea of renaming the variable "vertical_tabs_responsive_path_blacklist" to "vertical_tabs_responsive_path_list" because this forces me to think about an upgrade path (delete old variables). So I would appreciate a new patch respecting this variable name or a new patch with an upgrade path.

bserem’s picture

@rcodina I agree with the variable naming.
As for the non-admin paths. In my case, we use vertical tabs on the user profile page, and do not want to provide visitors access to the theme (seven).

Like I said in my first post, these patches are an idea/work to see if this module fits our needs. I had to adapt it a bit, and these are the results. Feel free to use anything you prefer from the above.
In the next days I'll be called to find a solution about vertical tabs on our site, lets see how this goes.

rcodina’s picture

Ok @bserem, then I will wait until you find out if this fits your needs. Then, I will test this, maybe do some changes and finally commit it with you as author.

Thanks for your interest in this module. I hope to keep improving it with community help!

rcodina’s picture

Status: Needs review » Needs work
tchopshop’s picture

I'd MUCH rather have whitelisting than blacklisting... Only allowing blacklisting means the module shows up in unexpected locations. It's more likely to be needed in one or two spots rather than the whole site.

thanks!

bserem’s picture

We went with a custom JS option, because we needed some fine control over our tabs. So, I didn't spend much more time this module.
However, you can build upon my patches to improve whitelist if needed.

rcodina’s picture

As soon as I have some time I will work on this. Today I begin my three weeks vacation time ;)

tchopshop’s picture

Thank you... have fun!

rcodina’s picture

Here comes my patch which solves both requests by @bserem. Please review it.

rcodina’s picture

Status: Needs work » Needs review

@tchopshop Please, test it too.

rcodina’s picture

I have done some testing and it works for me.

rcodina’s picture

  • rcodina committed 9201aa7 on 7.x-1.x
    Issue #2509488 by bserem, rcodina: Option to enable module on non admin...
rcodina’s picture

Please, test this. I don't want to create a new release with this without another positive review. Now this is on dev branch of module to make it easier to test changes. Many thanks!

rcodina’s picture

Status: Needs review » Fixed

This is now fixed. It is on brand new 1.0-rc1 version.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.