the iCalcreator url in the .make file is incorrect and is stopping my builds. The url should not use git:// but rather https://

Patch attached.

CommentFileSizeAuthor
date_ical-iCalcreator-make.patch381 bytessherakama
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sherakama’s picture

Status: Active » Needs review
coredumperror’s picture

Status: Needs review » Closed (works as designed)

That make file was already changed in the 3.4 release of Date iCal. Please update to that version to fix the problem you're having.

sherakama’s picture

Status: Closed (works as designed) » Needs review

Thanks for fixing this issue in the 3.x version of the module. I am working on updating a number of sites. Any chance you can backport that fix to the dev branch of the 2.x version? It would help until I can get around to updating to the 3.x branch for everything.

coredumperror’s picture

Oh dang, I completely missed that you posted this against the 2.x-dev branch. I haven't actually committed to that branch is over a year and a half, but I'll see what I can do.

coredumperror’s picture

Status: Needs review » Fixed

Alright, Date iCal 7.x-2.14 is now available, and it uses the same make file as the 3.x branch. This is especially important because the old 2.x makefile tried to install the latest version of iCalcreator, which as of a few months ago is no longer compatible with Date iCal. The iCalcreator author changed the naming conventions in the library in the 2.22 release, so Date iCal needs to stick to 2.20.2. The new makefile downloads that version specifically.

sherakama’s picture

Awesome!

Thanks for the quick turn around.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.