Noticing that ajax.js if not loaded in the header can cause issues with ajax links if clicked before the js in the footer is loaded.

Thinking this will require the following to be in the head if ajax.js is used on the page.
jquery.js
jquery.once.js

And maybe these as well
drupal.js
inline Drupal.settings

Not sure about jquery-ui if that's needed in the header as well.

CommentFileSizeAuthor
#10 advagg-2508583-9-fix-perf.patch27.95 KBmikeytown2
#8 advagg-2508583-7-footer-3-cache-fix.patch9.17 KBmikeytown2
#6 advagg-2508583-6-fix-aggressive-cache.patch7.92 KBmikeytown2
#3 advagg-2508583-2-all-in-footer-list.patch6.52 KBmikeytown2
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mikeytown2’s picture

mikeytown2 CreditAttribution: mikeytown2 commented

Made this configurable via hook_advagg_mod_get_lists_alter

  • mikeytown2 committed 0052846 on 7.x-2.x 
    Issue #2508583 by mikeytown2: Allow for the all in footer behavior to...
mikeytown2’s picture

mikeytown2 CreditAttribution: mikeytown2 commented
Status: Active » Fixed
FileSize
advagg-2508583-2-all-in-footer-list.patch6.52 KB
mikeytown2’s picture

mikeytown2 CreditAttribution: mikeytown2 commented
Status: Fixed » Needs work

Doesn't work with the aggressive render cache.

mikeytown2’s picture

mikeytown2 CreditAttribution: mikeytown2 commented

I'll need to look into this more... looks complicated like usual.

mikeytown2’s picture

mikeytown2 CreditAttribution: mikeytown2 commented
Status: Needs work » Needs review
FileSize
advagg-2508583-6-fix-aggressive-cache.patch7.92 KB

I'll be going over this tomorrow.

  • mikeytown2 committed d5b1845 on 7.x-2.x 
    Issue #2508583 by mikeytown2: Move JS to the footer - new level and fix...
mikeytown2’s picture

mikeytown2 CreditAttribution: mikeytown2 commented
Status: Needs review » Fixed
FileSize
advagg-2508583-7-footer-3-cache-fix.patch9.17 KB

  • mikeytown2 committed f2af7df on 7.x-2.x 
    Issue #2508583 by mikeytown2: Get the agressive cache speed back.
mikeytown2’s picture

mikeytown2 CreditAttribution: mikeytown2 commented
FileSize
advagg-2508583-9-fix-perf.patch27.95 KB

Got back most of the speed by calling a sub set of advagg_mod_js_alter instead of the whole thing.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

praveen_91’s picture

praveen_91 CreditAttribution: praveen_91 commented
Component: AdvAgg Modifier » Code

Hi, mikeytown2
I am using Advanced CSS/JS Aggregation module every things work for me but when i have use "Move JS to the footer" => All but JavaScript Libraries option,
then i am getting issue with "jui_dropdown". its icon not show (dropdown icon).
thanks for your help.

mikeytown2’s picture

mikeytown2 CreditAttribution: mikeytown2 commented

@praveen_91
Please open up a new issue for help with http://www.pontikis.net/labs/jui_dropdown/. Give a full example of how to reproduce the bug you are having.