In ds/modules/ds_extras/includes/ds_extras.admin.inc, line 576:

if ($value != 0 && $key == $value) {

Should be changed to:

if ($value !== 0 && $key == $value) {

Any string the can't be converted to a number will equal the number zero so $value != 0 is similar to 0 != 0 which will obviously return false.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

aspilicious’s picture

Not again... :(

I thought I had fixed that. Let me dig through the history to see if I can spot the commits that affected that line.

aspilicious’s picture

aspilicious’s picture

Status: Active » Needs review
FileSize
1.31 KB
aspilicious’s picture

Status: Needs review » Fixed
aspilicious’s picture

Version: 7.x-2.10 » 8.x-2.x-dev
Status: Fixed » Needs work

  • aspilicious committed 5a68baf on 7.x-2.x
    Issue #2507163 by aspilicious: Block regions cannot be deleted following...

  • aspilicious committed f1f693a on 8.x-2.x
    Issue #2507163 by aspilicious: Block regions cannot be deleted
    
aspilicious’s picture

Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.