Problem/Motivation

Every unit test had a Test[Class] class for the plugin it was testing so we could set the module handler and database, this is no longer needed as shown in: https://www.drupal.org/node/2503861#comment-10019681

Proposed resolution

Remove all test classes.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#3 interdiff.txt742 bytesbenjy
#3 2505521-3.patch21.55 KBbenjy
#2 2505521-2.patch21.55 KBbenjy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

benjy’s picture

benjy CreditAttribution: benjy at CodeDrop commented
Issue summary: View changes
benjy’s picture

benjy CreditAttribution: benjy at CodeDrop commented
Status: Active » Needs review
FileSize
2505521-2.patch21.55 KB

Something like this.

benjy’s picture

benjy CreditAttribution: benjy at CodeDrop commented
FileSize
2505521-3.patch21.55 KB
interdiff.txt742 bytes

Removed an extra newline.

chx’s picture

chx CreditAttribution: chx commented
Status: Needs review » Reviewed & tested by the community

Wonderful!!

benjy’s picture

benjy CreditAttribution: benjy at CodeDrop commented
Issue summary: View changes

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: 2505521-3.patch, failed testing.

benjy queued 3: 2505521-3.patch for re-testing.

benjy’s picture

benjy CreditAttribution: benjy at CodeDrop commented
Status: Needs work » Reviewed & tested by the community

Setting back to RTBC, Looks like bot had an issue.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Nice tidy up. Committed 3700144 and pushed to 8.0.x. Thanks!

diff --git a/core/modules/migrate/tests/src/Unit/MigrateSqlSourceTestCase.php b/core/modules/migrate/tests/src/Unit/MigrateSqlSourceTestCase.php
index eb28dce..98180d5 100644
--- a/core/modules/migrate/tests/src/Unit/MigrateSqlSourceTestCase.php
+++ b/core/modules/migrate/tests/src/Unit/MigrateSqlSourceTestCase.php
@@ -76,7 +76,7 @@ protected function setUp() {
     $migration->expects($this->any())
       ->method('getHighWater')
       ->will($this->returnValue(static::ORIGINAL_HIGH_WATER));
-    
+
     // Setup the plugin.
     $plugin_class = static::PLUGIN_CLASS;
     $plugin = new $plugin_class($this->migrationConfiguration['source'], $this->migrationConfiguration['source']['plugin'], array(), $migration, $entity_manager);

Fixed whitespace on commit.

  • alexpott committed 3700144 on 8.0.x 
    Issue #2505521 by benjy: Clean-up un-need test classes in migrate_drupal

  • alexpott committed 6bb1ba3 on 8.0.x 
    Issue #2505521 by benjy: Clean-up un-need test classes in migrate_drupal
  • alexpott committed 7bd866a on 8.0.x
    Revert "Issue #2505521 by benjy: Clean-up un-need test classes in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.