Select Display Field Collection is a module that display the content of a Field Collection filtered by a select.

This module is similar to Quicktabs field collection, but does not use Quicktabs.

https://www.drupal.org/sandbox/vendramini/2504837 (project sandbox page)
https://www.drupal.org/project/2504837/git-instructions (link to git instructions for the project)

Drupal version: 7

CONFIGURATION

1. Go to the Manage Display page for any Entity that contains a
field-collection field.
2. Change the formatter to Select Display
3. Click the gear icon on the right to access the formatter settings.
4. (REQUIRED) Select the field to use for the select values.
5. (REQUIRED) Select the field to use for the select contents.
6. Optionally tick the box to strip all HTML tags from the select content.

Comments

PA robot’s picture

Status: Active » Needs work

Git clone failed for http://git.drupal.org/sandbox/vendramini/2504837.git while invoking http://pareview.sh/pareview/httpgitdrupalorgsandboxvendramini2504837git

Git clone failed. Aborting.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

rrfegade’s picture

Hi Vendramini,
Please go through the below comments and correct your code accordingly.

Automated Review

There are many errors reported by the automated code review tool, Please correct them first, here is the report: http://pareview.sh/pareview/httpgitdrupalorgsandboxvendramini2504837git

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
No: Causes module duplication and/or fragmentation. Field Collection List formatter, There are alredy few smiler kind of modules avialable on drupal.org, so you co collaboratively work with them as aad this feature to that existing modules, for this you can follow the instructions from the duplication and/or fragmentation.document
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
No: Dose not Follows the licensing requirements. Please remove the LICENSE.txt file this file will be automatically added to your project once its approved
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
No: Does not follow the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements.
Coding style & Drupal API usage
List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:
  1. (*) Module is a duplicate
  2. (*) Doesn't follow README guidelines
  3. (*) There are few unused variables in module file
  4. (*) There are many code sniffer errors

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

This review uses the Project Application Review Template.

daffodilsoftware’s picture

Hi Vendramini,
During commuting module ,Always remember some things
>>Never add variable that are not used .
$delta , $collection_id , $key
>>Never add in module
LICENSE.txt exist
>>Never increase any line limit to 80 other pareview will show errors
>>Try to add space( ) means new line at the end of file some time it gives error

May be you should add this link in description of module for now till module is in sandbox
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/Vendramini/2504837.git select_display_field_collection

After these changes ,
http://pareview.sh/pareview/httpgitdrupalorgsandboxvendramini2504837git
and repeat review and when go for next step

PA robot’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

apaderno’s picture

Assigned: Vendramini » Unassigned
Issue tags: -Module review