Problem/Motivation

\Drupal\Component\Plugin\Factory\DefaultFactory relies on plugin providers, which are a \Drupal\Core concept.

Proposed resolution

Remove this dependency on plugin providers from the exception message.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Beta phase evaluation

<

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug because existing functionality doesn't work as expected.
Issue priority Normal because its problem in very unlikely situations
Unfrozen changes Unfrozen because it only changes one exception message
Prioritized changes Non prioritized change
CommentFileSizeAuthor
#4 drupal_2504995_4.patch2.94 KBXano
#4 interdiff.txt2.07 KBXano
#1 drupal_2504995_1.patch883 bytesXano
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Xano’s picture

Status: Active » Needs review
FileSize
883 bytes
Xano’s picture

This would never have been found without #2458789: Introduce PluginDefinitionInterface, because our QA test listeners can only check whether code in \Drupal\Component depends on logic from \Drupal\Core, not if it depends on core conceptually.

Status: Needs review » Needs work

The last submitted patch, 1: drupal_2504995_1.patch, failed testing.

Xano’s picture

Status: Needs work » Needs review
FileSize
2.07 KB
2.94 KB
lauriii’s picture

Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Patch looks sane. Added also beta evaluation

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: drupal_2504995_4.patch, failed testing.

Status: Needs work » Needs review

Xano queued 4: drupal_2504995_4.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 4: drupal_2504995_4.patch, failed testing.

Status: Needs work » Needs review

Xano queued 4: drupal_2504995_4.patch for re-testing.

Xano’s picture

Status: Needs review » Reviewed & tested by the community

Back to RTBC, because the failures were caused by testbot hiccups.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Yep a dev is going to need to be able to read PSR-4 namespaces so we're losing nothing here. Committed ca81e99 and pushed to 8.0.x. Thanks!

Thanks for adding the beta eval to the issue summary.

  • alexpott committed ca81e99 on 8.0.x
    Issue #2504995 by Xano: Component DefaultFactory relies on core's...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.